From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: doc-view support for bookmark.el
Date: Tue, 25 Dec 2007 18:07:32 -0500 [thread overview]
Message-ID: <jwvlk7ie5p8.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87prwu77ug.fsf@member.fsf.org> (Tassilo Horn's message of "Tue, 25 Dec 2007 23:00:39 +0100")
> + (if handler
> + (funcall handler bookmark)
> + (bookmark-jump-noselect bookmark))))
Aka (funcall (or handler 'bookmark-jump-noselect) bookmark)
> Do you think it's ok and I should install it?
Looks good from a cursory glance at it, although the repetition of all those
bookmark-get-handler + if + funcall is begging for some redundancy-reduction.
Stefan
next prev parent reply other threads:[~2007-12-25 23:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-25 10:54 doc-view support for bookmark.el Tassilo Horn
2007-12-25 11:43 ` Stefan Monnier
2007-12-25 14:42 ` Tassilo Horn
2007-12-25 17:32 ` Stefan Monnier
2007-12-25 19:00 ` Tassilo Horn
2007-12-25 22:00 ` Tassilo Horn
2007-12-25 22:05 ` Nick Roberts
2007-12-25 22:25 ` Tassilo Horn
2007-12-25 23:07 ` Stefan Monnier [this message]
2007-12-26 8:22 ` Tassilo Horn
2007-12-26 11:52 ` bookmark support for doc-view and image-mode (was: doc-view support for bookmark.el) Tassilo Horn
2007-12-26 18:53 ` doc-view support for bookmark.el Karl Fogel
2007-12-26 17:08 ` Drew Adams
2007-12-26 20:21 ` Karl Fogel
2007-12-27 9:21 ` Tassilo Horn
2007-12-27 15:34 ` Drew Adams
2007-12-28 9:10 ` Karl Fogel
2007-12-28 23:44 ` Kim F. Storm
2007-12-29 7:40 ` Karl Fogel
2007-12-29 7:43 ` Stefan Monnier
2007-12-30 0:34 ` Kim F. Storm
2008-01-02 2:18 ` Stefan Monnier
2008-01-02 9:43 ` Kim F. Storm
2008-01-02 20:22 ` Stefan Monnier
2007-12-25 17:24 ` Drew Adams
2007-12-25 17:54 ` martin rudalics
2007-12-25 18:43 ` Tassilo Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvlk7ie5p8.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.