From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: generated-autoload-file sometimes not created Date: Wed, 09 Apr 2008 16:16:14 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1207772191 32458 80.91.229.12 (9 Apr 2008 20:16:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 9 Apr 2008 20:16:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 09 22:17:04 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Jjgj9-0002pg-QE for ged-emacs-devel@m.gmane.org; Wed, 09 Apr 2008 22:17:04 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JjgiV-0002Sa-RW for ged-emacs-devel@m.gmane.org; Wed, 09 Apr 2008 16:16:23 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JjgiS-0002SU-U6 for emacs-devel@gnu.org; Wed, 09 Apr 2008 16:16:21 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JjgiR-0002SI-E1 for emacs-devel@gnu.org; Wed, 09 Apr 2008 16:16:20 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JjgiR-0002SF-Bd for emacs-devel@gnu.org; Wed, 09 Apr 2008 16:16:19 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JjgiM-0008So-O1; Wed, 09 Apr 2008 16:16:14 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AlMFAAHB/EfO+KV8/2dsb2JhbACBXKo8 X-IronPort-AV: E=Sophos;i="4.25,630,1199682000"; d="scan'208";a="18235225" Original-Received: from smtp.pppoe.ca (HELO smtp.teksavvy.com) ([65.39.196.238]) by ironport2-out.teksavvy.com with ESMTP; 09 Apr 2008 16:16:14 -0400 Original-Received: from pastel.home ([206.248.165.124]) by smtp.teksavvy.com (Internet Mail Server v1.0) with ESMTP id PYZ30514; Wed, 09 Apr 2008 16:16:14 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 181A38958; Wed, 9 Apr 2008 16:16:14 -0400 (EDT) In-Reply-To: (Glenn Morris's message of "Wed, 09 Apr 2008 14:51:44 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:94807 Archived-At: > I have locally added (rightly, I think) calc/calc-loaddefs.el to > AUTOGENEL in lisp/Makefile.in. However, it is not recreated on > bootstrapping if the timestamp of calc/*.el is older than that of > loaddefs.el (at least, I think this is what is happening). I believe > this indicates a bug in the code that generates autoload files. Indeed, we have a problem: "make bootstrap" will not recreate all the autoloads, but only those of the files that are more recent than ldefs-boot.el. So I suggest the patch below. Can someone test it and fix/install it? Stefan Index: lisp/loadup.el =================================================================== RCS file: /sources/emacs/emacs/lisp/loadup.el,v retrieving revision 1.162 diff -u -r1.162 loadup.el --- lisp/loadup.el 9 Apr 2008 03:44:26 -0000 1.162 +++ lisp/loadup.el 9 Apr 2008 20:15:12 -0000 @@ -81,7 +81,13 @@ (message "Lists of integers (garbage collection statistics) are normal output") (message "while building Emacs; they do not indicate a problem.") (message "%s" (garbage-collect)) -(load "loaddefs.el") ;Don't get confused if someone compiled this by mistake. + +(condition-case nil + ;; Don't get confused if someone compiled this by mistake. + (load "loaddefs.el") + ;; In case loaddefs hasn't been generated yet. + (file-error (load "ldefs-boot.el"))) + (message "%s" (garbage-collect)) (load "simple") Index: lisp/Makefile.in =================================================================== RCS file: /sources/emacs/emacs/lisp/Makefile.in,v retrieving revision 1.104 diff -u -r1.104 Makefile.in --- lisp/Makefile.in 8 Apr 2008 22:12:12 -0000 1.104 +++ lisp/Makefile.in 9 Apr 2008 20:15:12 -0000 @@ -277,11 +277,8 @@ bootstrap-prepare: if test -x $(EMACS); then \ $(MAKE) $(MFLAGS) autoloads; \ - else \ - cp $(lisp)/ldefs-boot.el $(lisp)/loaddefs.el; \ fi - chmod +w $(lisp)/loaddefs.el \ - $(lisp)/ps-print.el \ + chmod +w $(lisp)/ps-print.el \ $(lisp)/emacs-lisp/cl-loaddefs.el maintainer-clean: distclean bootstrap-clean