From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Adding parameters to windows Date: Fri, 23 May 2008 15:47:17 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1211572084 8716 80.91.229.12 (23 May 2008 19:48:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 23 May 2008 19:48:04 +0000 (UTC) Cc: emacs-devel@gnu.org To: joakim@verona.se Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 23 21:48:42 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JzdFk-0005gt-Vp for ged-emacs-devel@m.gmane.org; Fri, 23 May 2008 21:48:37 +0200 Original-Received: from localhost ([127.0.0.1]:41583 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JzdF0-0007KD-Ei for ged-emacs-devel@m.gmane.org; Fri, 23 May 2008 15:47:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JzdEv-0007Ig-Pc for emacs-devel@gnu.org; Fri, 23 May 2008 15:47:45 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JzdEt-0007G6-TV for emacs-devel@gnu.org; Fri, 23 May 2008 15:47:45 -0400 Original-Received: from [199.232.76.173] (port=45509 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JzdEt-0007Fy-Nt for emacs-devel@gnu.org; Fri, 23 May 2008 15:47:43 -0400 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]:33329) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JzdEt-0006O0-Cc for emacs-devel@gnu.org; Fri, 23 May 2008 15:47:43 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 9FE452CFBF7; Fri, 23 May 2008 15:47:40 -0400 (EDT) Original-Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 1D3493FE0; Fri, 23 May 2008 15:47:18 -0400 (EDT) Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id CC81941BEC; Fri, 23 May 2008 15:47:17 -0400 (EDT) In-Reply-To: (joakim@verona.se's message of "Fri, 23 May 2008 16:10:19 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:97609 Archived-At: Your patch needs a few tweaks, e.g. to adjust it to the coding conventions: - The docstring of window-parameters is poor. E.g. the first line doesn't say anything. The second line is indented in the source, which looks bad when you do C-h f window-parameters. nil is an aliast as well, so there's no need to mention it explicitly. - I'd prefer to have `window-parameter' rather than `window-parameters'. - The docstring of set-window-parameter needs to start with a capital letter and end with a "." and should mention its arguments. Feel free to plagiarize set-frame-parameter. - The comment for window_parameters refers to `pin' and `group'. - See http://www.gnu.org/prep/standards/standards.html#Change-Logs for the format to use in ChangeLogs: - put together changes to a file. - your changelog seems to say you've changed `DEFUN'. - there's a missing space after colon in "(window:Added". - And the "Added" should be "Add" of course. Thank you very much for your help. BTW, could you point me to your latest version of the pin&group patch? Stefan > === modified file 'src/window.c' > --- src/window.c 2008-04-03 02:15:43 +0000 > +++ src/window.c 2008-04-29 09:40:34 +0000 > @@ -275,6 +278,7 @@ p-> frame = Qnil; p-> display_table = Qnil; p-> dedicated = Qnil; > + p->window_parameters = Qnil; p-> pseudo_window_p = 0; > bzero (&p->cursor, sizeof (p->cursor)); > bzero (&p->last_cursor, sizeof (p->last_cursor)); > @@ -1325,6 +1329,38 @@ > return w->dedicated; > } > +DEFUN ("window-parameters", Fwindow_parameters, Swindow_parameters, > + 1, 1, 0, > + doc: /* Return WINDOW's window-parameters. > + returns nil or an alist where values affect window operations. */) > + (window) > + Lisp_Object window; > +{ > + return decode_window (window)->window_parameters; > +} > + > + > +DEFUN ("set-window-parameter", Fset_window_parameter, > + Sset_window_parameter, 3, 3, 0, > + doc: /* set window parameters */) > + (window, prop, val) > + Lisp_Object window, prop, val; > +{ > + register struct window *w = decode_window (window); > + register Lisp_Object old_alist_elt; > + > + old_alist_elt = Fassq (prop, w->window_parameters); > + if (EQ (old_alist_elt, Qnil)) > + w->window_parameters = Fcons (Fcons (prop, val), w->window_parameters); > + else > + Fsetcdr (old_alist_elt, val); > + > + //Fplist_put(w->window_parameters,key,value); > + > + return w->window_parameters; > +} > + > + > DEFUN ("window-display-table", Fwindow_display_table, Swindow_display_table, > 0, 1, 0, > doc: /* Return the display-table that WINDOW is using. > @@ -7714,6 +7771,9 @@ > defsubr (&Sset_window_vscroll); > defsubr (&Scompare_window_configurations); > defsubr (&Swindow_list); > + defsubr (&Swindow_parameters); > + defsubr (&Sset_window_parameter); > + > } > void > === modified file 'src/window.h' > --- src/window.h 2008-01-29 02:05:10 +0000 > +++ src/window.h 2008-04-29 10:04:07 +0000 > @@ -229,6 +229,11 @@ > enlarged. */ > Lisp_Object orig_total_lines, orig_top_line; > + /* an alist with flags that modifies behaviour of certain window operations. > + currently "pin" and "group" are special > + */ > + Lisp_Object window_parameters; > + > /* No Lisp data may follow below this point without changing > mark_object in alloc.c. The member current_matrix must be the > first non-Lisp member. */ > -- > Joakim Verona