data-directory

data-directory

[Kazu Yamamoto]

Hello all,

My program creates a tool-bar as follows:

(defun mew-toolbar-make (map alist)
  (let ((tool-bar-map (make-sparse-keymap)) ;; for tool-bar-add-item-from-menu
	(data-directory mew-icon-directory))
    (dolist (a alist)
      (if (fboundp 'tool-bar-local-item-from-menu)
	  ;; Emacs 21.3.50 or later
	  (tool-bar-local-item-from-menu (car a) (cdr a) tool-bar-map map)
	;; Emacs 21.3 or earlier
	;; The target map is tool-bar-map
	(tool-bar-add-item-from-menu (car a) (cdr a) map)))
    tool-bar-map))

On Emacs 22, the tool-bar is created correctly. However, on CVS HEAD
Emacs, icon images are not displayed.

image-load-path contains the data-directory symbol. So, I think the
locally bound value to data-directory should be used.

Is this behavior change intentional? Or just a bug?

--Kazu

Re: data-directory

[Stefan Monnier]

> (defun mew-toolbar-make (map alist)
>   (let ((tool-bar-map (make-sparse-keymap)) ;; for tool-bar-add-item-from-menu
> 	(data-directory mew-icon-directory))
>     (dolist (a alist)
>       (if (fboundp 'tool-bar-local-item-from-menu)
> 	  ;; Emacs 21.3.50 or later
> 	  (tool-bar-local-item-from-menu (car a) (cdr a) tool-bar-map map)
> 	;; Emacs 21.3 or earlier
> 	;; The target map is tool-bar-map
> 	(tool-bar-add-item-from-menu (car a) (cdr a) map)))
>     tool-bar-map))

> On Emacs 22, the tool-bar is created correctly. However, on CVS HEAD
> Emacs, icon images are not displayed.

> image-load-path contains the data-directory symbol. So, I think the
> locally bound value to data-directory should be used.

> Is this behavior change intentional? Or just a bug?

It's neither a bug nor intentional. ;-)
The image selection has now been postponed to the point when the toolbar
is displayed, which is outside of the scope of the let.
I'll see how we can try and remember the data-directory.


        Stefan

Re: data-directory

[Stefan Monnier]

>> (defun mew-toolbar-make (map alist)
>> (let ((tool-bar-map (make-sparse-keymap)) ;; for tool-bar-add-item-from-menu
>> (data-directory mew-icon-directory))
>> (dolist (a alist)
>> (if (fboundp 'tool-bar-local-item-from-menu)
>> ;; Emacs 21.3.50 or later
>> (tool-bar-local-item-from-menu (car a) (cdr a) tool-bar-map map)
>> ;; Emacs 21.3 or earlier
>> ;; The target map is tool-bar-map
>> (tool-bar-add-item-from-menu (car a) (cdr a) map)))
>> tool-bar-map))

>> On Emacs 22, the tool-bar is created correctly. However, on CVS HEAD
>> Emacs, icon images are not displayed.

>> image-load-path contains the data-directory symbol. So, I think the
>> locally bound value to data-directory should be used.

>> Is this behavior change intentional? Or just a bug?

> It's neither a bug nor intentional. ;-)
> The image selection has now been postponed to the point when the toolbar
> is displayed, which is outside of the scope of the let.
> I'll see how we can try and remember the data-directory.

Could you explain why you let-bind data-directory rather than
image-load-path?


        Stefan