From: Stefan Monnier <monnier@iro.umontreal.ca>
To: jasonr@f2s.com
Cc: Magnus Henoch <mange@freemail.hr>, 716@emacsbugs.donarmstrong.com
Subject: bug#716: Bug in buffer-swap-text
Date: Tue, 23 Dec 2008 21:41:22 -0500 [thread overview]
Message-ID: <jwvlju6z4ak.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <1230081428.49518d94a3a08@webmail.freedom2surf.net> (jasonr@f2s.com's message of "Wed, 24 Dec 2008 01:17:08 +0000")
>> Your analysis sounds right, thank you. I'd suggest to use another
>> r_alloc primitve, something like r_alloc_reset_variable, so you could do
> I've adapted your suggestion so it does not remove the consistency check in
> find_bloc (instead it does a non-checking find inline):
Thanks. After your email, I thought we could just change
r_alloc_reset_variable to take 2 arguments: the old ptr and the
new ptr. This way, you get more consistency checking.
BTW, if the double check (p->variable == ptr && p->data == *ptr) is
there for consistency, it would be good to add a comment about it.
Better yet: make it a real consistency check, along the lines of
assert (*p->variable == p->data);
so it's not just checked for `ptr', but for all blocs visited in the loop.
Stefan
next prev parent reply other threads:[~2008-12-24 2:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-08 10:41 bug#716: Bug in buffer-swap-text Geoff Gole
2008-11-08 12:51 ` Magnus Henoch
2008-12-02 22:58 ` Stefan Monnier
2008-12-03 0:11 ` jasonr
2008-12-03 2:44 ` Stefan Monnier
2008-12-03 2:55 ` jasonr
2008-12-23 12:45 ` Jason Rumney
2008-12-23 14:51 ` Jason Rumney
2008-12-23 15:14 ` Jason Rumney
2008-12-23 17:23 ` Stefan Monnier
2008-12-23 23:15 ` Jason Rumney
2008-12-24 1:17 ` jasonr
2008-12-24 2:41 ` Stefan Monnier [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-12-03 15:25 Geoff Gole
2008-12-03 15:42 ` Jason Rumney
2008-12-03 15:46 ` Geoff Gole
2008-12-03 20:42 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvlju6z4ak.fsf-monnier+emacsbugreports@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=716@emacsbugs.donarmstrong.com \
--cc=jasonr@f2s.com \
--cc=mange@freemail.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.