From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Virtual Info files and nodes Date: Mon, 29 Jun 2009 02:14:19 +0200 Message-ID: References: <87ws6wnj3s.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1246234487 11924 80.91.229.12 (29 Jun 2009 00:14:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 29 Jun 2009 00:14:47 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 29 02:14:39 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ML4W5-0004Fk-NK for ged-emacs-devel@m.gmane.org; Mon, 29 Jun 2009 02:14:38 +0200 Original-Received: from localhost ([127.0.0.1]:44001 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ML4W4-0007Cs-QC for ged-emacs-devel@m.gmane.org; Sun, 28 Jun 2009 20:14:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ML4W0-0007B0-4N for emacs-devel@gnu.org; Sun, 28 Jun 2009 20:14:32 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ML4Vu-00078m-Ey for emacs-devel@gnu.org; Sun, 28 Jun 2009 20:14:30 -0400 Original-Received: from [199.232.76.173] (port=33296 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ML4Vu-00078j-Bb for emacs-devel@gnu.org; Sun, 28 Jun 2009 20:14:26 -0400 Original-Received: from smtp-01.vtx.ch ([212.147.0.84]:52293) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ML4Vt-0008Lw-Vt for emacs-devel@gnu.org; Sun, 28 Jun 2009 20:14:26 -0400 Original-Received: from alfajor.home (dyn.144-85-222-231.dsl.vtx.ch [144.85.222.231]) by smtp-01.vtx.ch (VTX Services SA) with ESMTP id 7C37D28103; Mon, 29 Jun 2009 02:14:19 +0200 (CEST) Original-Received: by alfajor.home (Postfix, from userid 20848) id 34F6964339; Mon, 29 Jun 2009 02:14:19 +0200 (CEST) In-Reply-To: <87ws6wnj3s.fsf@mail.jurta.org> (Juri Linkov's message of "Mon, 29 Jun 2009 00:28:38 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.94 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:111798 Archived-At: > I'd like to present a patch that properly implements virtual Info files > and nodes. It plugs in to just three functions in the Info package and > provides an API to redefine these functions to dynamically generate > either a virtual file or a virtual node: It looks fairly good. I have a few comments/questions: - Can't it be pushed a bit further to make it handle the "dir" special case as well? - Why regexps for filenames? - Why ^...$ when you really mean \`...\'? - Why check (stringp filename) in Info-virtual-file? Isn't it an error to call it with something else than a string. - Why have separate Info-virtual-file and Info-virtual-node functions? (the latter is only called (once) from Info-virtual-fun, and the former is called once from Info-virtual-fun and another time where it seems that Info-virtual-fun could be used in its stead). Stefan