From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#4599: 23.1.50; VC (CVS) fails to show directory status Date: Wed, 30 Sep 2009 15:59:18 -0400 Message-ID: References: <877hvgzj5a.fsf@leeloo.anubex.internal> <200909301653.n8UGrwU0018764@godzilla.ics.uci.edu> Reply-To: Stefan Monnier , 4599@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1254346435 11091 80.91.229.12 (30 Sep 2009 21:33:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 30 Sep 2009 21:33:55 +0000 (UTC) Cc: Tim Van Holder , 4599@emacsbugs.donarmstrong.com To: Dan Nicolaescu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 30 23:33:47 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Mt6nz-0000m0-EV for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Sep 2009 23:33:47 +0200 Original-Received: from localhost ([127.0.0.1]:40454 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mt6ny-00048O-O4 for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Sep 2009 17:33:46 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mt5SG-0003Dm-U4 for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2009 16:07:16 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mt5SB-00035R-Oq for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2009 16:07:16 -0400 Original-Received: from [199.232.76.173] (port=51883 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mt5SB-000359-IF for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2009 16:07:11 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:41899) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mt5SA-00079f-E5 for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2009 16:07:11 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8UK77ZE008928; Wed, 30 Sep 2009 13:07:07 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8UK55mD007965; Wed, 30 Sep 2009 13:05:05 -0700 Resent-Date: Wed, 30 Sep 2009 13:05:05 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Wed, 30 Sep 2009 20:05:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4599 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4599-submit@emacsbugs.donarmstrong.com id=B4599.12543407676956 (code B ref 4599); Wed, 30 Sep 2009 20:05:05 +0000 Original-Received: (at 4599) by emacsbugs.donarmstrong.com; 30 Sep 2009 19:59:27 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ironport2-out.pppoe.ca (ironport2-out.teksavvy.com [206.248.154.181]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8UJxPZt006951 for <4599@emacsbugs.donarmstrong.com>; Wed, 30 Sep 2009 12:59:27 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsEAJ5Vw0pMCrXH/2dsb2JhbACBUNcghCcEhw+Cag X-IronPort-AV: E=Sophos;i="4.44,481,1249272000"; d="scan'208";a="46865218" Original-Received: from 76-10-181-199.dsl.teksavvy.com (HELO pastel.home) ([76.10.181.199]) by ironport2-out.pppoe.ca with ESMTP; 30 Sep 2009 15:59:19 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 6E0328109; Wed, 30 Sep 2009 15:59:18 -0400 (EDT) In-Reply-To: <200909301653.n8UGrwU0018764@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Wed, 30 Sep 2009 09:53:58 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Wed, 30 Sep 2009 16:07:16 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31605 Archived-At: > +2009-09-29 Stefan Monnier > + > + * vc-hooks.el (vc-dir-buffers): New var. > + (vc-state-refresh): New function. > + (vc-state): Use it. > + (vc-after-save): Always ask the backend to recompute the new state. > + Always call vc-dir if necessary, using vc-dir-buffers. > + * vc-dir.el (vc-dir-prepare-status-buffer, vc-dir-resynch-file): > + Use vc-dir-buffers. > + (vc-dir-mode): Use vc-dir-buffers rather than after-save-hook. > + (vc-dir-prepare-status-buffer, vc-dir-update) > + (vc-dir-resync-directory-files, vc-dir-resynch-file, vc-dir-mode): > + Don't call expand-file-name on default-directory. > in particular the removal or the expand-file-name calls is incorrect. > At least ~ needs to be expanded, otherwise things just do not work. While it might be the immediate cause of the problem, I think the removal of expand-file-name calls might still be right: the code that sets default-directory to a value starting with "~/" might be the one that should be changed. Stefan