all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: Tim Van Holder <tim.vanholder@gmail.com>,
	4599@emacsbugs.donarmstrong.com
Subject: bug#4599: 23.1.50; VC (CVS) fails to show directory status
Date: Wed, 30 Sep 2009 15:59:18 -0400	[thread overview]
Message-ID: <jwvljjw2oju.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <200909301653.n8UGrwU0018764@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Wed, 30 Sep 2009 09:53:58 -0700 (PDT)")

> +2009-09-29  Stefan Monnier  <address@hidden>
> +
> +       * vc-hooks.el (vc-dir-buffers): New var.
> +       (vc-state-refresh): New function.
> +       (vc-state): Use it.
> +       (vc-after-save): Always ask the backend to recompute the new state.
> +       Always call vc-dir if necessary, using vc-dir-buffers.
> +       * vc-dir.el (vc-dir-prepare-status-buffer, vc-dir-resynch-file):
> +       Use vc-dir-buffers.
> +       (vc-dir-mode): Use vc-dir-buffers rather than after-save-hook.
> +       (vc-dir-prepare-status-buffer, vc-dir-update)
> +       (vc-dir-resync-directory-files, vc-dir-resynch-file, vc-dir-mode):
> +       Don't call expand-file-name on default-directory.

> in particular the removal or the expand-file-name calls is incorrect.
> At least ~ needs to be expanded, otherwise things just do not work.

While it might be the immediate cause of the problem, I think the
removal of expand-file-name calls might still be right: the code that
sets default-directory to a value starting with "~/" might be the one
that should be changed.


        Stefan





  reply	other threads:[~2009-09-30 19:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-30 12:55 bug#4599: 23.1.50; VC (CVS) fails to show directory status Tim Van Holder
2009-09-30 16:53 ` Dan Nicolaescu
2009-09-30 19:59   ` Stefan Monnier [this message]
2009-10-01  2:19     ` Stefan Monnier
2009-10-01  8:38       ` Tim Van Holder
2009-10-01 14:11         ` Stefan Monnier
2009-10-01 16:22           ` Dan Nicolaescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvljjw2oju.fsf-monnier+emacsbugreports@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=4599@emacsbugs.donarmstrong.com \
    --cc=dann@ics.uci.edu \
    --cc=tim.vanholder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.