From: Stefan Monnier <monnier@iro.umontreal.ca>
To: MON KEY <monkey@sandpframing.com>
Cc: 4819@emacsbugs.donarmstrong.com, bug-gnu-emacs@gnu.org
Subject: bug#4819: file-truename's undocumented behavior
Date: Wed, 28 Oct 2009 20:37:53 -0400 [thread overview]
Message-ID: <jwvljivca9q.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <d2afcfda0910281301l2a21de4eu618d29258848863d@mail.gmail.com> (MON KEY's message of "Wed, 28 Oct 2009 16:01:32 -0400")
> I assumed nil.
That would be very unexpected, since file-truename otherwise always
returns a string when passed a string.
> However, discarding the state of my "least surprisedness", I would
> _not_ expect that file-truename would step all over the match-data,
> and where it does so not before first:
Most functions don't preserve the match-data, and even more so for
functions that manipulate strings or buffers.
> b) Noting that it does so in the documention. i.e. as per `split-string'.
It's the other way around: the few functions that preserve the
match-data should be documented as such (better yet: the byte-compiler
should be taught about them, so it can detect when we use the
match-data after it got clobbered).
>>> I just spent 2 1/2 hours in a break-loop three functions away trying
>>> to debug _undocumented_ behavior.
>> Which part of the documentation do you think this behavior contradicts?
> This part:
> (file-name-absolute-p "") ;=> nil
> (file-symlink-p "") ;=> nil
That's not a part of the documentation.
> Why not mention in the docs that on w32 `w32-long-file-name' may be
> a more suitable alternative esp. as it is a primitive and as it will
> expand "8.3 DOS" short name aliases in the process. (Again, per
> _existing_ comments in body of `file-truename's definition).
Elisp should generally not be w32-specific, so ratehr than use
w32-long-file-name we should maybe change
file-truename correspondingly. That doesn't mean I think it's the right
thing to do: I know next to nothing about this issue.
> ! ((and (string= (substring filename 0 1) "~")
> ! (string-match-p "~[^/]*/?" filename))
> ! (string-match "~[^/]*/?" filename)
> ! (let ((first-part
> ! (substring filename 0 (match-end 0)))
> ! (rest (substring filename (match-end 0))))
What's the point? If you're going to use string-match in the end, you
might as well do it right away.
Stefan
next prev parent reply other threads:[~2009-10-29 0:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-28 0:28 bug#4819: file-truename's undocumented behavior MON KEY
2009-10-28 1:52 ` Stefan Monnier
2009-10-28 20:01 ` MON KEY
2009-10-29 0:37 ` Stefan Monnier [this message]
2009-10-29 0:56 ` Lennart Borgman
2009-11-07 0:01 ` MON KEY
2011-07-09 5:51 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvljivca9q.fsf-monnier+emacsbugreports@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=4819@emacsbugs.donarmstrong.com \
--cc=bug-gnu-emacs@gnu.org \
--cc=monkey@sandpframing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.