bug#6883: 23.2; `read-key' echos keys in the minibuffer

bug#6883: 23.2; `read-key' echos keys in the minibuffer

[Leo]

1. Define bookmark-read-search-input as this which inserts a (sit-for 1) to
demonstrate the bug easily:

(defun bookmark-read-search-input ()
  (let ((prompt       (propertize "Pattern: " 'face 'minibuffer-prompt))
        (tmp-list     ()))
    (while
        (let ((char (read-key (concat prompt bookmark-search-pattern))))
          (sit-for 1)
          (case char
            ((?\e ?\r) nil) ; RET or ESC break the search loop.
            (?\C-g (setq bookmark-quit-flag t) nil)
            (?\d (pop tmp-list) t) ; Delete last char of pattern with DEL
            (t
             (if (characterp char)
                 (push char tmp-list)
               (setq unread-command-events
                     (nconc (mapcar 'identity
                                    (this-single-command-raw-keys))
                            unread-command-events))
               nil))))
      (setq bookmark-search-pattern
            (apply 'string (reverse tmp-list))))))

2. and eval

  (let (bookmark-search-pattern) (bookmark-read-search-input))

3. then start typing away.

You should see each key is echoed. So for example if you hit backspace
you may see backspace or DEL in the echo area twice.

With the original definition back (ie without the sit-for) you can
observe a trail for each key you type by for example doing something
like this:

  1. C-x r l to list bookmarks
  2. M-g s and start typing away

That breaks the smooth flow of key strokes.

Thierry Volpiatto, YAMAMOTO Mitsuharu and I can observe this on all
three major platforms. On some platforms, it happens so fast that it is
hardly annoying, on others you can read the echoing literally.
`read-char' does not have this problem and thus Thierry's suggestion to
use it instead.

Leo

bug#6883: 23.2; `read-key' echos keys in the minibuffer

[Stefan Monnier]

Does the trivial patch below fix the problem?


        Stefan


=== modified file 'lisp/subr.el'
--- lisp/subr.el	2010-07-10 18:52:53 +0000
+++ lisp/subr.el	2010-08-21 07:45:07 +0000
@@ -1818,6 +1818,7 @@
 some sort of escape sequence, the ambiguity is resolved via `read-key-delay'."
   (let ((overriding-terminal-local-map read-key-empty-map)
 	(overriding-local-map nil)
+        (echo-keystrokes 0)
 	(old-global-map (current-global-map))
         (timer (run-with-idle-timer
                 ;; Wait long enough that Emacs has the time to receive and

bug#6883: 23.2; `read-key' echos keys in the minibuffer

[Leo]

On 2010-08-21 08:52 +0100, Stefan Monnier wrote:
> Does the trivial patch below fix the problem?
>
>         Stefan
>
> === modified file 'lisp/subr.el'
> --- lisp/subr.el	2010-07-10 18:52:53 +0000
> +++ lisp/subr.el	2010-08-21 07:45:07 +0000
> @@ -1818,6 +1818,7 @@
>  some sort of escape sequence, the ambiguity is resolved via `read-key-delay'."
>    (let ((overriding-terminal-local-map read-key-empty-map)
>  	(overriding-local-map nil)
> +        (echo-keystrokes 0)
>  	(old-global-map (current-global-map))
>          (timer (run-with-idle-timer
>                  ;; Wait long enough that Emacs has the time to receive and
>

Yes and thanks.

Leo

bug#6883: 23.2; `read-key' echos keys in the minibuffer

[Stefan Monnier]

>> Does the trivial patch below fix the problem?
> Yes and thanks.

Great, I've installed it in the emacs-23 branch,


        Stefan

bug#6883: 23.2; `read-key' echos keys in the minibuffer

[Thierry Volpiatto]

Leo <sdl.web@gmail.com> writes:

> On 2010-08-21 08:52 +0100, Stefan Monnier wrote:
>> Does the trivial patch below fix the problem?
>>
>>         Stefan
>>
>> === modified file 'lisp/subr.el'
>> --- lisp/subr.el	2010-07-10 18:52:53 +0000
>> +++ lisp/subr.el	2010-08-21 07:45:07 +0000
>> @@ -1818,6 +1818,7 @@
>>  some sort of escape sequence, the ambiguity is resolved via `read-key-delay'."
>>    (let ((overriding-terminal-local-map read-key-empty-map)
>>  	(overriding-local-map nil)
>> +        (echo-keystrokes 0)
>>  	(old-global-map (current-global-map))
>>          (timer (run-with-idle-timer
>>                  ;; Wait long enough that Emacs has the time to receive and
>>
>
> Yes and thanks.

Glad this is fixed, thanks Stefan.

-- 
Thierry Volpiatto
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997