From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Emacs-diffs Digest, Vol 94, Issue 89 Date: Sat, 25 Sep 2010 00:25:10 +0200 Message-ID: References: <83zkv7rmpe.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1285367201 3220 80.91.229.12 (24 Sep 2010 22:26:41 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 24 Sep 2010 22:26:41 +0000 (UTC) Cc: Lars Magne Ingebrigtsen , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 25 00:26:39 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OzGiR-000217-5R for ged-emacs-devel@m.gmane.org; Sat, 25 Sep 2010 00:26:38 +0200 Original-Received: from localhost ([127.0.0.1]:33728 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OzGiO-0004Ao-5S for ged-emacs-devel@m.gmane.org; Fri, 24 Sep 2010 18:26:00 -0400 Original-Received: from [140.186.70.92] (port=51226 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OzGiI-0004Ad-IH for emacs-devel@gnu.org; Fri, 24 Sep 2010 18:25:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OzGhc-000840-Bl for emacs-devel@gnu.org; Fri, 24 Sep 2010 18:25:21 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:57664) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OzGhc-00083v-6V for emacs-devel@gnu.org; Fri, 24 Sep 2010 18:25:12 -0400 Original-Received: from dyn.83-228-173-129.dsl.vtx.ch ([83.228.173.129]:13843 helo=fmsmemgm.homelinux.net) by fencepost.gnu.org with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1OzGhb-000335-8Y; Fri, 24 Sep 2010 18:25:11 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id C9A2A6611D; Sat, 25 Sep 2010 00:25:10 +0200 (CEST) In-Reply-To: <83zkv7rmpe.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 24 Sep 2010 21:00:29 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:130813 Archived-At: >> - int frame_lines = FRAME_LINES (frame); >> + EMACS_INT frame_lines = FRAME_LINES (frame); > Is this really a good idea? There's no chance the number of lines in > a frame will overflow a 32-bit int any time soon. SO I think an > explicit cast to int is a better solution here. BTW, if you add casts, as much as possible add them only inside macros, Stefan