all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: 3 bugs in Rmail
Date: Mon, 10 Jan 2011 16:28:05 -0500	[thread overview]
Message-ID: <jwvlj2sjvs3.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <871v4kzfvs.fsf@stupidchicken.com> (Chong Yidong's message of "Mon, 10 Jan 2011 15:02:31 -0500")

>> http://lists.gnu.org/archive/html/help-gnu-emacs/2011-01/msg00315.html
> In mail-mode, C-c C-c deletes the window and returns to the Rmail buffer
> because of this specialized code in mail-bury:

>         (with-current-buffer
>             (window-buffer (next-window (selected-window) 'not))
>           (setq rmail-flag (eq major-mode 'rmail-mode))
>           ...)
>    (if rmail-flag
>        ;; If the Rmail buffer has a summary, show that.
>        (if summary-buffer (switch-to-buffer summary-buffer)
>          (delete-window))
>      (switch-to-buffer newbuf))))))

> So, one solution is to add this to message-bury, or make message-bury an
> alias for mail-bury.  But this code doesn't seem terribly clean.

Yes, it's pretty hackish and ugly.

> A better alternative may be to specify a `mail-bury-function' variable,
> let Rmail set that variable, and change both mail-mode and message-mode
> to respect `mail-bury-function'.  Anyone have any better ideas?

Maybe rather than mail-bury-function, it could be
a mail-callback-function, i.e. not meant explicitly for burying but more
generally for returning to the caller.  I guess the difference would be
only in the name, tho.


        Stefan



  reply	other threads:[~2011-01-10 21:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-10 18:37 3 bugs in Rmail Eli Zaretskii
2011-01-10 20:02 ` Chong Yidong
2011-01-10 21:28   ` Stefan Monnier [this message]
2011-01-12 17:25     ` Chong Yidong
2011-01-12 20:40       ` Stefan Monnier
2011-01-12 21:48         ` Chong Yidong
2011-01-10 22:47 ` Glenn Morris
2011-01-11  4:09   ` Eli Zaretskii
2011-01-11  7:39     ` Glenn Morris
2011-01-11  7:44       ` Glenn Morris
2011-01-11  7:55       ` Glenn Morris
2011-01-12  3:53       ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvlj2sjvs3.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=cyd@stupidchicken.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.