all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lute Kamstra <Lute.Kamstra.lists@xs4all.nl>
Cc: emacs-devel@gnu.org
Subject: Re: Passing flags using vc-do-command
Date: Mon, 14 Mar 2011 09:43:50 -0400	[thread overview]
Message-ID: <jwvlj0hvmzz.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87mxl0pwqj.fsf@speer.lan> (Lute Kamstra's message of "Sat, 12 Mar 2011 09:29:56 +0100")

> + (defvar vc-post-command-1-functions nil
> +   "Hook run at the end of `vc-do-command-1'.
> + Each function is called inside the buffer in which the command
> + was run and is passed 4 arguments: the COMMAND, the FILE-OR-LIST,
> + the BEFORE-FLAGS and the AFTER-FLAGS.")

Do we really need that?

> ! (defun vc-do-command-1 (buffer okstatus command file-or-list
> ! 			&optional before-flag-or-list &rest after-flags)

I'd rather a nicer name for the new command.
And I'd like it to address some of the other needs of backends,
e.g. paying attention to vc-<backend>-program.  So I think we should
look at the calls to vc-do-command (and to
call-process/start-process/...) in backends to try and design the
successor to vc-do-command.


        Stefan



  parent reply	other threads:[~2011-03-14 13:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-07 17:53 Passing flags using vc-do-command Lute Kamstra
2011-03-07 23:02 ` Stefan Monnier
2011-03-09  6:32   ` Lute Kamstra
2011-03-09 18:21     ` Stefan Monnier
2011-03-10 13:58       ` Andy Moreton
2011-03-11  1:52         ` Stefan Monnier
2011-03-12  8:40         ` Lute Kamstra
2011-03-12  8:29       ` Lute Kamstra
2011-03-14 11:35         ` Lute Kamstra
2011-03-14 13:43         ` Stefan Monnier [this message]
2011-03-14 15:16           ` Lute Kamstra
2011-03-15  2:06             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvlj0hvmzz.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=Lute.Kamstra.lists@xs4all.nl \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.