From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109131: Return more descriptive data from Fgarbage_collect. Date: Wed, 18 Jul 2012 02:33:11 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1342593202 29024 80.91.229.3 (18 Jul 2012 06:33:22 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 18 Jul 2012 06:33:22 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 18 08:33:22 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SrNp2-0007bP-G6 for ged-emacs-devel@m.gmane.org; Wed, 18 Jul 2012 08:33:20 +0200 Original-Received: from localhost ([::1]:49462 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrNp1-0005OR-Iw for ged-emacs-devel@m.gmane.org; Wed, 18 Jul 2012 02:33:19 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55660) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrNoz-0005OH-6p for emacs-devel@gnu.org; Wed, 18 Jul 2012 02:33:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SrNoy-0007gM-7x for emacs-devel@gnu.org; Wed, 18 Jul 2012 02:33:17 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:47853) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrNoy-0007gI-4N for emacs-devel@gnu.org; Wed, 18 Jul 2012 02:33:16 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q6I6XCjk016033; Wed, 18 Jul 2012 02:33:13 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id C75D7AE508; Wed, 18 Jul 2012 02:33:11 -0400 (EDT) In-Reply-To: (Dmitry Antipov's message of "Wed, 18 Jul 2012 09:44:36 +0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4282=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4282> : streams <786500> : uri <1168211> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151718 Archived-At: Thanks, it's getting there. > + ((CONS INTERNAL-SIZE USED-CONSES FREE-CONSES) > + (SYMBOL INTERNAL-SIZE USED-SYMBOLS FREE-SYMBOLS) > + (MISC INTERNAL-SIZE USED-MISCS FREE-MISCS) > + (STRING INTERNAL-SIZE USED-STRINGS USED-STRING-BYTES FREE-STRING) > + (VECTOR INTERNAL-SIZE USED-VECTORS USED-VECTOR-BYTES FREE-VECTOR-BYTES) > + (FLOAT INTERNAL-SIZE USED-FLOATS FREE-FLOATS) > + (INTERVAL INTERNAL-SIZE USED-INTERVALS FREE-INTERVALS) > + (BUFFER INTERNAL-SIZE USED-BUFFERS)) That's not regular enough. Every entry in the list should have the same shape (NAME SIZE USED FREE). For buffers, (buffers SIZE USED) is OK because that's like having FREE set to nil, but for strings (STRING INTERNAL-SIZE USED-STRINGS USED-STRING-BYTES FREE-STRING) is not good, we want instead to have 2 entries: (strings SIZE USED FREE) and (string-bytes 1 USED FREE) same for vectors, where we need one entry for vectors and another for vector slots (and BTW, please keep it vector slots rather than vector bytes: the SIZE part is there specifically so that code that requires byte counts can do the conversion later). And please add one last entry for the malloc data. Stefan