all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109131: Return more descriptive data from Fgarbage_collect.
Date: Wed, 18 Jul 2012 02:33:11 -0400	[thread overview]
Message-ID: <jwvliih60ws.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <E1SrNZW-0003vA-5g@vcs.savannah.gnu.org> (Dmitry Antipov's message of "Wed, 18 Jul 2012 09:44:36 +0400")

Thanks, it's getting there.

> + ((CONS INTERNAL-SIZE USED-CONSES FREE-CONSES)
> +  (SYMBOL INTERNAL-SIZE USED-SYMBOLS FREE-SYMBOLS)
> +  (MISC INTERNAL-SIZE USED-MISCS FREE-MISCS)
> +  (STRING INTERNAL-SIZE USED-STRINGS USED-STRING-BYTES FREE-STRING)
> +  (VECTOR INTERNAL-SIZE USED-VECTORS USED-VECTOR-BYTES FREE-VECTOR-BYTES)
> +  (FLOAT INTERNAL-SIZE USED-FLOATS FREE-FLOATS)
> +  (INTERVAL INTERNAL-SIZE USED-INTERVALS FREE-INTERVALS)
> +  (BUFFER INTERNAL-SIZE USED-BUFFERS))

That's not regular enough.  Every entry in the list should have the
same shape (NAME SIZE USED FREE).  For buffers, (buffers SIZE USED) is OK
because that's like having FREE set to nil, but for strings (STRING
INTERNAL-SIZE USED-STRINGS USED-STRING-BYTES FREE-STRING) is not good,
we want instead to have 2 entries:

  (strings SIZE USED FREE)
and
  (string-bytes 1 USED FREE)

same for vectors, where we need one entry for vectors and another for
vector slots (and BTW, please keep it vector slots rather than vector
bytes: the SIZE part is there specifically so that code that requires
byte counts can do the conversion later).

And please add one last entry for the malloc data.


        Stefan



       reply	other threads:[~2012-07-18  6:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1SrNZW-0003vA-5g@vcs.savannah.gnu.org>
2012-07-18  6:33 ` Stefan Monnier [this message]
2012-07-18  9:38   ` [Emacs-diffs] /srv/bzr/emacs/trunk r109131: Return more descriptive data from Fgarbage_collect Dmitry Antipov
2012-07-18 10:46     ` Stefan Monnier
2012-07-18 12:46       ` Dmitry Antipov
2012-07-19  7:55         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvliih60ws.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=dmantipov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.