From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#12632: file permissions checking mishandled when setuid Date: Mon, 22 Oct 2012 20:40:15 -0400 Message-ID: References: <5078CAB6.7020509@cs.ucla.edu> <83sj9g4vy7.fsf@gnu.org> <507BAA6C.2000601@cs.ucla.edu> <83lif74p78.fsf@gnu.org> <507C823D.40304@cs.ucla.edu> <83d30j3wqg.fsf@gnu.org> <507CF802.6000305@cs.ucla.edu> <83a9vm4bmv.fsf@gnu.org> <50818763.80501@cs.ucla.edu> <83wqymz4me.fsf@gnu.org> <5081A1DF.9000009@cs.ucla.edu> <5081ABD6.9060002@cs.ucla.edu> <23r4osd2f9.fsf@fencepost.gnu.org> <50836366.6080600@cs.ucla.edu> <5084E1B2.2020105@cs.ucla.edu> <83ipa2ctl2.fsf@gnu.org> <5085AD9E.7040701@cs.ucla.edu> <838vaycj65.fsf@gnu.org> <5085BB01.2030402@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1350952879 15763 80.91.229.3 (23 Oct 2012 00:41:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Oct 2012 00:41:19 +0000 (UTC) Cc: 12632@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 23 02:41:27 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TQSYf-0001xn-JJ for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Oct 2012 02:41:25 +0200 Original-Received: from localhost ([::1]:34838 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQSYY-0004Us-35 for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Oct 2012 20:41:18 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37246) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQSYV-0004Ui-6L for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 20:41:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQSYT-0004nj-VB for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 20:41:14 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46263) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQSYT-0004nV-S9 for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 20:41:13 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TQSaE-0004a4-Io for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 20:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Oct 2012 00:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security patch Original-Received: via spool by 12632-submit@debbugs.gnu.org id=B12632.135095293417549 (code B ref 12632); Tue, 23 Oct 2012 00:43:02 +0000 Original-Received: (at 12632) by debbugs.gnu.org; 23 Oct 2012 00:42:14 +0000 Original-Received: from localhost ([127.0.0.1]:56514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQSZS-0004Yz-8b for submit@debbugs.gnu.org; Mon, 22 Oct 2012 20:42:14 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:4027) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQSZP-0004Yh-CH for 12632@debbugs.gnu.org; Mon, 22 Oct 2012 20:42:11 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09FpYC//2dsb2JhbABEDrQDgQiCFQEBBAFWIxALNBIUGA0kiBwFugmQRAOjM4FYgjBV X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="202506739" Original-Received: from 69-165-128-191.dsl.teksavvy.com (HELO pastel.home) ([69.165.128.191]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 22 Oct 2012 20:40:16 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 8914D59347; Mon, 22 Oct 2012 20:40:15 -0400 (EDT) In-Reply-To: <5085BB01.2030402@cs.ucla.edu> (Paul Eggert's message of "Mon, 22 Oct 2012 14:30:41 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65889 Archived-At: >> We use IS_DIRECTORY_SEP in other places, so why avoid it here? > If it's not needed, it makes the code a bit harder to read. I don't see why. The name says very clearly what it is intended to do. On the contrary, it seems more clear than comparing with '/' which only makes sense if you happen to know that / is the special char used as directory-separator. Stefan