From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/emacs-24 r111088: * net/tramp-sh.el (tramp-set-file-uid-gid): Convert UID and GID to
Date: Thu, 03 Jan 2013 11:28:32 -0500 [thread overview]
Message-ID: <jwvlicacjuo.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87y5gfyh3p.fsf@gmx.de> (Michael Albinus's message of "Sun, 30 Dec 2012 11:22:34 +0100")
>>> * net/tramp-sh.el (tramp-set-file-uid-gid): Convert UID and GID to
>>> integers, if they are real numbers. (Bug#13282)
>> Why is that TRT? Or more specifically, why do we get floats here?
>> They should only happen when the number is too large to be represented
>> as a fixnum.
> That's exactly the reason. See <http://thread.gmane.org/gmane.emacs.tramp/8022/focus=8024>.
But I don't see anything in the patch which checks that `round' returned
the right value (i.e. we now always return integers and never floats,
even if the value is too large to be represented as an integer).
Stefan
next prev parent reply other threads:[~2013-01-03 16:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1TorcE-0005AU-EH@vcs.savannah.gnu.org>
2012-12-29 20:37 ` [Emacs-diffs] /srv/bzr/emacs/emacs-24 r111088: * net/tramp-sh.el (tramp-set-file-uid-gid): Convert UID and GID to Stefan Monnier
2012-12-30 10:22 ` Michael Albinus
2013-01-03 16:28 ` Stefan Monnier [this message]
2013-01-04 9:47 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvlicacjuo.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.