Re: [Emacs-diffs] /srv/bzr/emacs/trunk r111707: * doc-view.el: Use (and prefer) soffice as default ODF->PDF

[Stefan Monnier <monnier@iro.umontreal.ca>]

> committer: Tassilo Horn <tsdh@gnu.org>
> branch nick: trunk
> timestamp: Sat 2013-02-09 10:58:48 +0100
> message:
>   * doc-view.el: Use (and prefer) soffice as default ODF->PDF
>   converter (Bug#13622).  Patch provided by Jambunathan K
>   <kjambunathan@gmail.com>.
>   (doc-view-unoconv-program): Make obsolete variable.
>   (doc-view-odf->pdf-converter-program): New variable.
>   (doc-view-odf->pdf-converter-function): New variable.
>   (doc-view-mode-p): Use it.
>   (doc-view-odf->pdf-converter-unoconv): Rename from
>   `doc-view-odf->pdf-converter-unoconv'.
>   (doc-view-odf->pdf-converter-soffice): New function.
>   (doc-view-convert-current-doc): Use
>   `doc-view-odf->pdf-converter-function'.
> modified:
>   lisp/ChangeLog
>   lisp/doc-view.el

> === modified file 'lisp/ChangeLog'
> --- a/lisp/ChangeLog	2013-02-09 05:52:20 +0000
> +++ b/lisp/ChangeLog	2013-02-09 09:58:48 +0000
> @@ -1,3 +1,18 @@
> +2013-02-09  Tassilo Horn  <tsdh@gnu.org>
> +
> +	* doc-view.el: Use (and prefer) soffice as default ODF->PDF
> +	converter (Bug#13622).  Patch provided by Jambunathan K
> +	<kjambunathan@gmail.com>.
> +	(doc-view-unoconv-program): Make obsolete variable.
> +	(doc-view-odf->pdf-converter-program): New variable.
> +	(doc-view-odf->pdf-converter-function): New variable.
> +	(doc-view-mode-p): Use it.
> +	(doc-view-odf->pdf-converter-unoconv): Rename from
> +	`doc-view-odf->pdf-converter-unoconv'.
> +	(doc-view-odf->pdf-converter-soffice): New function.
> +	(doc-view-convert-current-doc): Use
> +	`doc-view-odf->pdf-converter-function'.

This change log is wrong, since it says you're the author.
It should instead start with

    2013-02-09  Jambunathan K  <kjambunathan@gmail.com>

This said, I have another question: assuming both soffice and unoconv
are installed.  Which of the two is preferable and why (e.g. faster or
gives better output)?


        Stefan