From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#17430: 24.4.50; minibuffer history forgets the first entry Date: Wed, 07 May 2014 09:55:57 -0400 Message-ID: References: <536A13F3.4090902@poczta.onet.pl> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1399471061 9728 80.91.229.3 (7 May 2014 13:57:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 7 May 2014 13:57:41 +0000 (UTC) Cc: 17430@debbugs.gnu.org To: Jarek Czekalski Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 07 15:57:34 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wi2Lb-0001Ym-91 for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 May 2014 15:57:23 +0200 Original-Received: from localhost ([::1]:41494 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wi2La-0008Sa-Uf for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 May 2014 09:57:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wi2LQ-0008Hq-88 for bug-gnu-emacs@gnu.org; Wed, 07 May 2014 09:57:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wi2LH-00083k-T6 for bug-gnu-emacs@gnu.org; Wed, 07 May 2014 09:57:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37275) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wi2LH-00083a-Qm for bug-gnu-emacs@gnu.org; Wed, 07 May 2014 09:57:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Wi2LH-00030a-Gh for bug-gnu-emacs@gnu.org; Wed, 07 May 2014 09:57:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 May 2014 13:57:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17430 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17430-submit@debbugs.gnu.org id=B17430.139947096711271 (code B ref 17430); Wed, 07 May 2014 13:57:03 +0000 Original-Received: (at 17430) by debbugs.gnu.org; 7 May 2014 13:56:07 +0000 Original-Received: from localhost ([127.0.0.1]:54383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wi2KN-0002vW-0K for submit@debbugs.gnu.org; Wed, 07 May 2014 09:56:07 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:7432) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wi2KJ-0002r2-Bs for 17430@debbugs.gnu.org; Wed, 07 May 2014 09:56:04 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVO4rwut/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzQSFBgNJIgECNIZF456B4Q4BKkZgWqDTCE X-IPAS-Result: ArYGAIDvNVO4rwut/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzQSFBgNJIgECNIZF456B4Q4BKkZgWqDTCE X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="61737050" Original-Received: from 184-175-11-173.dsl.teksavvy.com (HELO pastel.home) ([184.175.11.173]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 07 May 2014 09:55:57 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 65E696054B; Wed, 7 May 2014 09:55:57 -0400 (EDT) In-Reply-To: <536A13F3.4090902@poczta.onet.pl> (Jarek Czekalski's message of "Wed, 07 May 2014 13:07:31 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:88730 Archived-At: > The history value is not properly initialized. Seems like r87775 > introduced a regression, because histval is not set to nil in minibuf.c. Indeed, thanks. > Stefan, could you review the patch? If I am to commit this, to which > branch? emacs-24? Looks good. Please install on emacs-24. But please also just initialize the variable directly in its declaration, as in: Lisp_Object histval = find_symbol_value (Vminibuffer_history_variable); -- Stefan