From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#18048: 24.3.92; [patch] eldoc improvements Date: Mon, 18 Aug 2014 15:32:36 -0400 Message-ID: References: <87egxjxkxh.fsf@gmail.com> <8738dx6a0g.fsf@gmail.com> <87y4vn2mu6.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1408390407 806 80.91.229.3 (18 Aug 2014 19:33:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 18 Aug 2014 19:33:27 +0000 (UTC) Cc: 18048-done@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 18 21:33:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XJSgC-0007su-F1 for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Aug 2014 21:33:20 +0200 Original-Received: from localhost ([::1]:45356 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJSgC-00015p-3s for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Aug 2014 15:33:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38858) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJSg2-00014g-Cd for bug-gnu-emacs@gnu.org; Mon, 18 Aug 2014 15:33:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XJSfu-0004JO-UZ for bug-gnu-emacs@gnu.org; Mon, 18 Aug 2014 15:33:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39514) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJSfu-0004JH-Rt for bug-gnu-emacs@gnu.org; Mon, 18 Aug 2014 15:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XJSfu-0003pM-If for bug-gnu-emacs@gnu.org; Mon, 18 Aug 2014 15:33:02 -0400 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Aug 2014 19:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 18048 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 18048@debbugs.gnu.org, monnier@IRO.UMontreal.CA, thierry.volpiatto@gmail.com Original-Received: via spool by 18048-done@debbugs.gnu.org id=D18048.140839036514671 (code D ref 18048); Mon, 18 Aug 2014 19:33:01 +0000 Original-Received: (at 18048-done) by debbugs.gnu.org; 18 Aug 2014 19:32:45 +0000 Original-Received: from localhost ([127.0.0.1]:46454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XJSfc-0003oY-Ji for submit@debbugs.gnu.org; Mon, 18 Aug 2014 15:32:44 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:46532) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XJSfZ-0003oQ-W7 for 18048-done@debbugs.gnu.org; Mon, 18 Aug 2014 15:32:42 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id s7IJWeBt015741; Mon, 18 Aug 2014 15:32:40 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 79D0EAE091; Mon, 18 Aug 2014 15:32:36 -0400 (EDT) In-Reply-To: <87y4vn2mu6.fsf@gmail.com> (Thierry Volpiatto's message of "Mon, 21 Jul 2014 09:24:50 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5038=0 X-NAI-Spam-Version: 2.3.0.9378 : core <5038> : inlines <1187> : streams <1267155> : uri <1804105> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92522 Archived-At: > I didn't find in help-fns.el, but in help.el I found > `help-function-arglist' which is used by eldoc. Hmm... no, this one does something different, so it definitely shouldn't skip &key and other CLisms. I installed a completely different patch in eldoc which uses help-make-usage so that the appearance is "as good as C-h f". This gives us "always upcase" arguments already, so there's no need to upcase them manually afterwards. So I also removed support for eldoc-argument-case, which is kind of a pain to implement properly. I also installed your &key handling patch, thanks. Stefan