all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: 18473@debbugs.gnu.org
Subject: bug#18473: 24.4.50; SEGFAULT when vconcatting more than 2048 vectors
Date: Mon, 15 Sep 2014 09:09:17 -0400	[thread overview]
Message-ID: <jwvlhplf39a.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <5416895B.4080807@yandex.ru> (Dmitry Antipov's message of "Mon, 15 Sep 2014 10:38:19 +0400")

> -	  set_backtrace_args (specpdl_ptr - 1, vals);
> -	  set_backtrace_nargs (specpdl_ptr - 1, XINT (numargs));
> +	  set_backtrace_args (backtrace_top (), vals, XINT (numargs));

I'm not thrilled at the idea of having to call backtrace_top every time,
instead of just using "specpdl_ptr - 1".  I'd much rather compute
specpdl_ptr - 1 before calling USE_SAFE_ALLOCA, for example.

BTW, don't we have the same problem for the subsequent call to
backtrace_debug_on_exit (and this one is worse because it is shared
among all the different kinds of calls, so we *really* don't want to
slow it down).


        Stefan





  reply	other threads:[~2014-09-15 13:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-14  2:37 bug#18473: 24.4.50; SEGFAULT when vconcatting more than 2048 vectors Michael Welsh Duggan
2014-09-14 17:10 ` Dmitry Antipov
2014-09-15  6:38   ` Dmitry Antipov
2014-09-15 13:09     ` Stefan Monnier [this message]
2014-09-15 15:04       ` Dmitry Antipov
2014-09-15 19:15         ` Stefan Monnier
2014-09-16  4:19           ` Dmitry Antipov
2014-09-23 15:52 ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvlhplf39a.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=18473@debbugs.gnu.org \
    --cc=dmantipov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.