From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juri Linkov <juri@jurta.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r118326: * lisp/minibuffer.el (minibuffer-completion-help): Compare this-command with completion-at-point.
Date: Thu, 04 Dec 2014 21:52:58 -0500 [thread overview]
Message-ID: <jwvlhmm6ccj.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1XnEvz-0006Ew-DD@vcs.savannah.gnu.org> (Juri Linkov's message of "Sat, 08 Nov 2014 22:56:43 +0000")
> - ,(if (and completion-in-region-mode-predicate
> + ;; Compare `this-command' with `completion-at-point'
> + ;; since `completion--in-region-1' sets `this-command'
> + ;; to this value for region completion commands.
> + ,(if (and (eq this-command 'completion-at-point)
Any reason we can't just check (eq (selected-window) (minibuffer-window))?
Stefan
next parent reply other threads:[~2014-12-05 2:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1XnEvz-0006Ew-DD@vcs.savannah.gnu.org>
2014-12-05 2:52 ` Stefan Monnier [this message]
2014-12-05 23:42 ` [Emacs-diffs] trunk r118326: * lisp/minibuffer.el (minibuffer-completion-help): Compare this-command with completion-at-point Juri Linkov
2014-12-06 5:15 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvlhmm6ccj.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.