* Re: [Emacs-diffs] scratch/outline 834612f 3/5: lisp/outline.el (outline-mode): Clean up docstring
[not found] ` <E1YGrqy-000842-B8@vcs.savannah.gnu.org>
@ 2015-01-30 6:20 ` Stefan Monnier
2015-01-30 8:16 ` Oleh Krehel
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2015-01-30 6:20 UTC (permalink / raw)
To: emacs-devel; +Cc: Oleh Krehel
>>>>> "Oleh" == Oleh Krehel <ohwoeowho@gmail.com> writes:
> branch: scratch/outline
> commit 834612fd984029b72f5c172bf3573aa7607fbe48
> Author: Oleh Krehel <ohwoeowho@gmail.com>
> Commit: Oleh Krehel <ohwoeowho@gmail.com>
> lisp/outline.el (outline-mode): Clean up docstring
> * lisp/outline.el (font-lock-warning-face): Remove unused declare.
> (outline-mode-prefix-map): Remove obsolete comment.
> (outline-font-lock-face): Remove obsolete comment.
This patch seems to contain a lot of gratuitous re-indentation and other
whitespace changes. This are fine in the code you change, but
not elsewhere.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Emacs-diffs] scratch/outline 834612f 3/5: lisp/outline.el (outline-mode): Clean up docstring
2015-01-30 6:20 ` [Emacs-diffs] scratch/outline 834612f 3/5: lisp/outline.el (outline-mode): Clean up docstring Stefan Monnier
@ 2015-01-30 8:16 ` Oleh Krehel
2015-01-30 8:58 ` Oleh Krehel
0 siblings, 1 reply; 3+ messages in thread
From: Oleh Krehel @ 2015-01-30 8:16 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
On Fri, Jan 30, 2015 at 7:20 AM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
>>>>>> "Oleh" == Oleh Krehel <ohwoeowho@gmail.com> writes:
>
>> branch: scratch/outline
>> commit 834612fd984029b72f5c172bf3573aa7607fbe48
>> Author: Oleh Krehel <ohwoeowho@gmail.com>
>> Commit: Oleh Krehel <ohwoeowho@gmail.com>
>
>> lisp/outline.el (outline-mode): Clean up docstring
>
>> * lisp/outline.el (font-lock-warning-face): Remove unused declare.
>> (outline-mode-prefix-map): Remove obsolete comment.
>> (outline-font-lock-face): Remove obsolete comment.
>
> This patch seems to contain a lot of gratuitous re-indentation and other
> whitespace changes. This are fine in the code you change, but
> not elsewhere.
Since I was making a change that would affect largely the whole file
in the subsequent commit, I changed the whitespace in the previous
commit, so that the next change would be easier to follow.
Should I redo the whole thing now to preserve the historical tabs?
I plan to make more changes in the future, the historical whitespace
will be overriden at some point eventually.
Oleh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] scratch/outline 834612f 3/5: lisp/outline.el (outline-mode): Clean up docstring
2015-01-30 8:16 ` Oleh Krehel
@ 2015-01-30 8:58 ` Oleh Krehel
0 siblings, 0 replies; 3+ messages in thread
From: Oleh Krehel @ 2015-01-30 8:58 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
On Fri, Jan 30, 2015 at 9:16 AM, Oleh Krehel <ohwoeowho@gmail.com> wrote:
> On Fri, Jan 30, 2015 at 7:20 AM, Stefan Monnier
> <monnier@iro.umontreal.ca> wrote:
>>>>>>> "Oleh" == Oleh Krehel <ohwoeowho@gmail.com> writes:
>>
>>> branch: scratch/outline
>>> commit 834612fd984029b72f5c172bf3573aa7607fbe48
>>> Author: Oleh Krehel <ohwoeowho@gmail.com>
>>> Commit: Oleh Krehel <ohwoeowho@gmail.com>
>>
>>> lisp/outline.el (outline-mode): Clean up docstring
>>
>>> * lisp/outline.el (font-lock-warning-face): Remove unused declare.
>>> (outline-mode-prefix-map): Remove obsolete comment.
>>> (outline-font-lock-face): Remove obsolete comment.
>>
>> This patch seems to contain a lot of gratuitous re-indentation and other
>> whitespace changes. This are fine in the code you change, but
>> not elsewhere.
Just finished undoing the whitespace changes. It's pushed as
scratch/outline-nowhitespace. Lesson learned, sorry for the noise.
Oleh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-30 8:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20150129162157.30895.36033@vcs.savannah.gnu.org>
[not found] ` <E1YGrqy-000842-B8@vcs.savannah.gnu.org>
2015-01-30 6:20 ` [Emacs-diffs] scratch/outline 834612f 3/5: lisp/outline.el (outline-mode): Clean up docstring Stefan Monnier
2015-01-30 8:16 ` Oleh Krehel
2015-01-30 8:58 ` Oleh Krehel
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.