From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Alan Mackenzie <acm@muc.de>
Subject: Re: [Emacs-diffs] master 4fabcbf: Fix debbugs#20240 part two (jit-lock error during `comment-dwim').
Date: Sat, 04 Apr 2015 09:56:56 -0400 [thread overview]
Message-ID: <jwvlhi8yp3n.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1YeLOK-0003dA-EL@vcs.savannah.gnu.org> (Alan Mackenzie's message of "Sat, 04 Apr 2015 10:33:28 +0000")
> - (run-hook-with-args 'jit-lock-after-change-extend-region-functions
> - start end old-len)
> - ;; Make sure we change at least one char (in case of deletions).
> - (setq jit-lock-end (min (max jit-lock-end (1+ start)) (point-max)))
> - ;; Request refontification.
> - (put-text-property jit-lock-start jit-lock-end 'fontified nil))
> + (save-restriction
> + (widen)
> + (run-hook-with-args 'jit-lock-after-change-extend-region-functions
> + start end old-len)
> + ;; Make sure we change at least one char (in case of deletions).
> + (setq jit-lock-end (min (max jit-lock-end (1+ start)) (point-max)))
> + ;; Request refontification.
> + (put-text-property jit-lock-start jit-lock-end 'fontified nil)))
Huh.. no, I said that widening during the call to
jit-lock-after-change-extend-region-functions was wrong. The widening
should only be around the put-text-property.
Stefan
next parent reply other threads:[~2015-04-04 13:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150404103328.13918.94798@vcs.savannah.gnu.org>
[not found] ` <E1YeLOK-0003dA-EL@vcs.savannah.gnu.org>
2015-04-04 13:56 ` Stefan Monnier [this message]
2015-04-04 14:18 ` [Emacs-diffs] master 4fabcbf: Fix debbugs#20240 part two (jit-lock error during `comment-dwim') Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvlhi8yp3n.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.