From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#20066: 24.4; should-error and cl-assert Date: Tue, 07 Apr 2015 22:05:11 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1428458781 29398 80.91.229.3 (8 Apr 2015 02:06:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 8 Apr 2015 02:06:21 +0000 (UTC) Cc: 20066@debbugs.gnu.org To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 08 04:06:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YffNb-0005cY-7s for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Apr 2015 04:06:11 +0200 Original-Received: from localhost ([::1]:50087 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YffNa-0003ci-7z for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Apr 2015 22:06:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YffNW-0003cQ-NW for bug-gnu-emacs@gnu.org; Tue, 07 Apr 2015 22:06:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YffNS-0004sS-MC for bug-gnu-emacs@gnu.org; Tue, 07 Apr 2015 22:06:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58844) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YffNS-0004sO-Ir for bug-gnu-emacs@gnu.org; Tue, 07 Apr 2015 22:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YffNS-0004cW-DU for bug-gnu-emacs@gnu.org; Tue, 07 Apr 2015 22:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Apr 2015 02:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20066 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20066-submit@debbugs.gnu.org id=B20066.142845871917704 (code B ref 20066); Wed, 08 Apr 2015 02:06:02 +0000 Original-Received: (at 20066) by debbugs.gnu.org; 8 Apr 2015 02:05:19 +0000 Original-Received: from localhost ([127.0.0.1]:48620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YffMk-0004bT-Sj for submit@debbugs.gnu.org; Tue, 07 Apr 2015 22:05:19 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:55574) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YffMj-0004bH-6K for 20066@debbugs.gnu.org; Tue, 07 Apr 2015 22:05:17 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgUFAGvvdVRBbthL/2dsb2JhbAA3gVOhb4EIgXUBAQQBViMQCw4mEhQYDSSIE6IRi3UEKkEJAwECgz4Dg3AEqDs X-IPAS-Result: AgUFAGvvdVRBbthL/2dsb2JhbAA3gVOhb4EIgXUBAQQBViMQCw4mEhQYDSSIE6IRi3UEKkEJAwECgz4Dg3AEqDs X-IronPort-AV: E=Sophos;i="5.01,1,1400040000"; d="scan'208";a="115665176" Original-Received: from 65-110-216-75.cpe.pppoe.ca (HELO pastel.home) ([65.110.216.75]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 07 Apr 2015 22:05:11 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 88F381209; Tue, 7 Apr 2015 22:05:11 -0400 (EDT) In-Reply-To: (Leo Liu's message of "Tue, 07 Apr 2015 15:44:45 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:101274 Archived-At: >> 1. (should-error (error "yes")) >> 2. (should-error (cl-assert nil t)) >> Test 1 succeeds but test 2 fails. I think test 2 is incorrect. It assumes that when cl-assert fails it reacts by throwing a "normal" signal that can be caught like any other. This is untrue for example when we decide to compile-away the assertions (depending on speed ans safety settings). cl-assert should be used to check impossible situations and an assertion failure is just supposed to bring it to the user's attention to help debug the code. It is not meant to be caught&handled like a normal signal. Stefan