Re: master 40d67a3: * lisp/loadup.el ("cus-start"): Load it after loaddefs.el

Re: master 40d67a3: * lisp/loadup.el ("cus-start"): Load it after loaddefs.el

[Glenn Morris]

Stefan Monnier wrote:

> --- a/lisp/loadup.el
> +++ b/lisp/loadup.el
> @@ -103,7 +103,6 @@
>  (load "bindings")
>  ;; This sets temporary-file-directory, used by eg
>  ;; auto-save-file-name-transforms in files.el.

^^^^^^^
The above comment refers to cus-start, and was meant to indicate that
cus-start should not be moved after files.

> -(load "cus-start")
>  (load "window")  ; Needed here for `replace-buffer-in-windows'.
>  (setq load-source-file-function 'load-with-code-conversion)
>  (load "files")
> @@ -144,6 +143,7 @@
>    ;; In case loaddefs hasn't been generated yet.
>    (file-error (load "ldefs-boot.el")))
>  
> +(load "cus-start")                    ;After loaddefs to autoload pcase-dolist.
>  (load "emacs-lisp/nadvice")
>  (load "emacs-lisp/cl-preloaded")
>  (load "minibuffer")            ;After loaddefs, for define-minor-mode.

Re: master 40d67a3: * lisp/loadup.el ("cus-start"): Load it after loaddefs.el

[Stefan Monnier]

>> --- a/lisp/loadup.el
>> +++ b/lisp/loadup.el
>> @@ -103,7 +103,6 @@
>> (load "bindings")
>> ;; This sets temporary-file-directory, used by eg
>> ;; auto-save-file-name-transforms in files.el.
> ^^^^^^^
> The above comment refers to cus-start, and was meant to indicate that
> cus-start should not be moved after files.

Hmm... According to files.el auto-save-file-name-transforms is
initialized with custom-initialize-delay, so its default value will be
(re)set when the dumped Emacs is started, at which point cus-start.el
has clearly been loaded.

Is the value of auto-save-file-name-transforms of importance during the
dumping process itself?


        Stefan

Re: master 40d67a3: * lisp/loadup.el ("cus-start"): Load it after loaddefs.el

[Glenn Morris]

I dunno.

IMO it's simpler to go back to not using pcase in cus-start, rather than
check whether every single option cus-start sets is needed in any of the
other files loadup used to load after cus-start and now loads before;
but YMMV.

Re: master 40d67a3: * lisp/loadup.el ("cus-start"): Load it after loaddefs.el

[Stefan Monnier]

> IMO it's simpler to go back to not using pcase in cus-start, rather than
> check whether every single option cus-start sets is needed in any of the
> other files loadup used to load after cus-start and now loads before;
> but YMMV.

So far I haven't seen any downside, and conceptually cus-start (which
mostly sets stuff for easy customization and is hence mostly a UI file)
should be loaded late, in my opinion.


        Stefan

Re: master 40d67a3: * lisp/loadup.el ("cus-start"): Load it after loaddefs.el

[Glenn Morris]

I think your change causes auto-save-file-name-transforms to show up in
customize-rogue output. I imagine this doesn't bother you, so please
just delete the now-irrelevant comment if you aren't moving the load back.

Re: master 40d67a3: * lisp/loadup.el ("cus-start"): Load it after loaddefs.el

[Stefan Monnier]

> I think your change causes auto-save-file-name-transforms to show up in
> customize-rogue output. I imagine this doesn't bother you, so please
> just delete the now-irrelevant comment if you aren't moving the load back.

I deleted the comment, fixed the rogue, and moved cus-start even later
to reduce the customize-rogues a bit further.


        Stefan