bug#20639: 24.5; nesting cl-tagbody

bug#20639: 24.5; nesting cl-tagbody

[Leo Liu]

1. eval the following

(let ((c 10))
  (cl-tagbody :next
     (cl-tagbody :next
        (print c)
        (cl-decf c)
        (when (zerop (mod c 2))
          (go :next)))
     (unless (<= c 0)
       (go :next))))

2. if: No catch for tag: #:cl--tagbody-tag, :next

Additionally eval the following

(let ((c 10))
  (cl-tagbody :next1
     (cl-tagbody :next2
        (print c)
        (cl-decf c)
        (when (zerop (mod c 2))
          (go :next2)))
     (unless (<= c 0)
       (go :next1))))

Error: cond: No catch for tag: #:cl--tagbody-tag, cl--exit

Leo

bug#20639: 24.5; nesting cl-tagbody

[Stefan Monnier]

>   (cl-tagbody :next
>      (cl-tagbody :next

Yay!  Someone's using cl-tagbody!?
I installed the patch below which should fix those problems,


        Stefan


diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el
index 27d3da3..636c543 100644
--- a/lisp/emacs-lisp/cl-macs.el
+++ b/lisp/emacs-lisp/cl-macs.el
@@ -1786,7 +1786,8 @@ Labels have lexical scope and dynamic extent."
       (unless (eq 'go (car-safe (car-safe block)))
         (push `(go cl--exit) block))
       (push (nreverse block) blocks))
-    (let ((catch-tag (make-symbol "cl--tagbody-tag")))
+    (let ((catch-tag (make-symbol "cl--tagbody-tag"))
+          (cl--tagbody-alist cl--tagbody-alist))
       (push (cons 'cl--exit catch-tag) cl--tagbody-alist)
       (dolist (block blocks)
         (push (cons (car block) catch-tag) cl--tagbody-alist))

bug#20639: 24.5; nesting cl-tagbody

[Leo Liu]

> Yay!  Someone's using cl-tagbody!?
> I installed the patch below which should fix those problems,

Thanks for the fix. I used it in a macro (could easily be rewritten
without it) and was getting errors.

Leo