Re: [Emacs-diffs] emacs-25 526d80c: Port chart.el methods to cl-generic.

Re: [Emacs-diffs] emacs-25 526d80c: Port chart.el methods to cl-generic.

[Stefan Monnier]

>     Port chart.el methods to cl-generic.

Thanks.

>     cl-call-next-method cannot be used inside EIEIO's defmethod.

I don't understand this comment: "call-next-method" doesn't seem to
appear within your patch.

>     * lisp/emacs-lisp/chart.el: Require cl-generic at compile time.

Actually, cl-generic is not a compile-time-only library: the cl-generic
macros expand to run-time calls to cl-generic functions.


        Stefan

Re: [Emacs-diffs] emacs-25 526d80c: Port chart.el methods to cl-generic.

[Mark Oteiza]

[-- Attachment #1: Type: text/plain, Size: 784 bytes --]

On Jan 1, 2016 9:14 AM, "Stefan Monnier" <monnier@iro.umontreal.ca> wrote:
> >     cl-call-next-method cannot be used inside EIEIO's defmethod.
>
> I don't understand this comment: "call-next-method" doesn't seem to
> appear within your patch.

It's the motivation for the patch. cl-call-next-method appears in two
chart-axis-draw methods.

> >     * lisp/emacs-lisp/chart.el: Require cl-generic at compile time.
>
> Actually, cl-generic is not a compile-time-only library: the cl-generic
> macros expand to run-time calls to cl-generic functions.

I see. Alternatively, both cl-defmethod and the function to which
it expands are autoloaded so requiring cl-generic isn't even
necessary.

Lots of libraries in Emacs using generics leave out the require. What do
you think I should do?

[-- Attachment #2: Type: text/html, Size: 1056 bytes --]

Re: [Emacs-diffs] emacs-25 526d80c: Port chart.el methods to cl-generic.

[Stefan Monnier]

> Lots of libraries in Emacs using generics leave out the require. What do
> you think I should do?

For bundled packages, cl-generic is preloaded, so the `require' is
unneeded tho harmless.  For unbundled packages relying on the
cl-generic.el compatibility library (distributed via GNU ELPA), both the
macros and the functions are supposedly all autoloaded, so again the
require should be unneeded tho harmless.

If the cl-generic.el compatibility library is installed by hand it's likely
that the autoloads aren't properly setup, in which case the `require'
would be needed, both at compile-time and at run-time.


        Stefan