From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 ef768c7: Cope with multiple overlapping faces. Date: Tue, 19 Jan 2016 09:37:09 -0500 Message-ID: References: <20160119124941.19061.82303@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1453214256 3453 80.91.229.3 (19 Jan 2016 14:37:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 19 Jan 2016 14:37:36 +0000 (UTC) Cc: Phillip Lord To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 19 15:37:20 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aLXPJ-0001Ue-UV for ged-emacs-devel@m.gmane.org; Tue, 19 Jan 2016 15:37:18 +0100 Original-Received: from localhost ([::1]:37334 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLXPJ-0005wx-EZ for ged-emacs-devel@m.gmane.org; Tue, 19 Jan 2016 09:37:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLXPG-0005wq-Aq for emacs-devel@gnu.org; Tue, 19 Jan 2016 09:37:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLXPD-0003uh-1B for emacs-devel@gnu.org; Tue, 19 Jan 2016 09:37:14 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:25638) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLXPC-0003u8-TQ for emacs-devel@gnu.org; Tue, 19 Jan 2016 09:37:10 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0A1FgA731xV/++PWxdcgxCEAoVVwwsEAgKBPDwRAQEBAQEBAYEKQQWDXQEBBFYjEAs0EhQYDYhjzyMBAQEBBgEBAQEeizqFBQcWhBcFi0RsjAuGXI4Wh1cjhBYggngBAQE X-IPAS-Result: A0A1FgA731xV/++PWxdcgxCEAoVVwwsEAgKBPDwRAQEBAQEBAYEKQQWDXQEBBFYjEAs0EhQYDYhjzyMBAQEBBgEBAQEeizqFBQcWhBcFi0RsjAuGXI4Wh1cjhBYggngBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="190275139" Original-Received: from 23-91-143-239.cpe.pppoe.ca (HELO pastel.home) ([23.91.143.239]) by ironport2-out.teksavvy.com with ESMTP; 19 Jan 2016 09:37:09 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 5FE555FF67; Tue, 19 Jan 2016 09:37:09 -0500 (EST) In-Reply-To: (Phillip Lord's message of "Tue, 19 Jan 2016 12:49:41 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:198357 Archived-At: > * lisp/htmlfontify.el (hfy-face-to-style-i): Treat inheritance right to > left. > (hfy-face-resolve-face): Handle font specification as well as font > name. Documentation update. (Bug#21990) I think even better would be to make the code use Emacs's own face-inheritance code. Not sure how that could work, but maybe something like (let ((tempface (make-symbol))) (make-face tempface) (face-set-attribute :inherit foo) (face-get-attribute ...)) [ Probably combined with some caching to avoid creating the same temp-face repeatedly. ] Stefan