From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#23785: Emacs 25: 'Undo' overdoes things. Date: Mon, 20 Jun 2016 10:04:01 -0400 Message-ID: References: <20160617150245.GB3316@acm.fritz.box> <83r3bvbuu1.fsf@gnu.org> <20160617174535.GD3316@acm.fritz.box> <83oa6zbmvd.fsf@gnu.org> <87ziqjwkrb.fsf@russet.org.uk> <83eg7vaq3z.fsf@gnu.org> <83bn2y9v80.fsf@gnu.org> <874m8oc9hc.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1466431550 29304 80.91.229.3 (20 Jun 2016 14:05:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 20 Jun 2016 14:05:50 +0000 (UTC) Cc: acm@muc.de, 23785@debbugs.gnu.org To: phillip.lord@russet.org.uk (Phillip Lord) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 20 16:05:40 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bEzpT-0003b7-Iu for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 Jun 2016 16:05:31 +0200 Original-Received: from localhost ([::1]:43844 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEzpS-0007QH-Qu for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 Jun 2016 10:05:30 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47179) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEzp4-0007Ah-JJ for bug-gnu-emacs@gnu.org; Mon, 20 Jun 2016 10:05:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bEzp0-0006eO-FD for bug-gnu-emacs@gnu.org; Mon, 20 Jun 2016 10:05:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35456) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEzp0-0006eI-Cg for bug-gnu-emacs@gnu.org; Mon, 20 Jun 2016 10:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bEzp0-0005XT-45 for bug-gnu-emacs@gnu.org; Mon, 20 Jun 2016 10:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Jun 2016 14:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23785 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23785-submit@debbugs.gnu.org id=B23785.146643145321229 (code B ref 23785); Mon, 20 Jun 2016 14:05:02 +0000 Original-Received: (at 23785) by debbugs.gnu.org; 20 Jun 2016 14:04:13 +0000 Original-Received: from localhost ([127.0.0.1]:47793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEzoD-0005WL-JJ for submit@debbugs.gnu.org; Mon, 20 Jun 2016 10:04:13 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:46684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEzoA-0005W4-36 for 23785@debbugs.gnu.org; Mon, 20 Jun 2016 10:04:11 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0A+FgA731xV/0P0SC1cgxCEAoVVwwsEAgKBPD0QAQEBAQEBAYEKQQWDXQEBAwFWIwULCzQSFBgNiFsIzyMBAQEBBgEBAQEeizqFBQeELQWfF5IUg1kjhBQigngBAQE X-IPAS-Result: A0A+FgA731xV/0P0SC1cgxCEAoVVwwsEAgKBPD0QAQEBAQEBAYEKQQWDXQEBAwFWIwULCzQSFBgNiFsIzyMBAQEBBgEBAQEeizqFBQeELQWfF5IUg1kjhBQigngBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="244719247" Original-Received: from 45-72-244-67.cpe.teksavvy.com (HELO pastel.home) ([45.72.244.67]) by ironport2-out.teksavvy.com with ESMTP; 20 Jun 2016 10:04:01 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 485ED64C54; Mon, 20 Jun 2016 10:04:01 -0400 (EDT) In-Reply-To: <874m8oc9hc.fsf@russet.org.uk> (Phillip Lord's message of "Mon, 20 Jun 2016 13:47:59 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119829 Archived-At: > I don't understand why you say this. AFAICT, the problem is that the > buffer-undo-list doesn't have a nil after the command has happened. Hmm... I thought I had seen a trace showing that there was a nil before the revert-buffer that then disappeared. But it looks like I misremember. Sorry. > I think that it does -- it calls "insert_from_buffer" which then calls > "prepare_to_modify_buffer". > I *think* what is happening is that prepare_to_modify_buffer is being > called when buffer-undo-list is specbound to t -- hence the change does > not register as undoable change. That would be a good explanation, indeed. So I guess your patch is the right fix. Thank you. Stefan