From: Stefan Monnier <monnier@iro.umontreal.ca>
To: phillip.lord@russet.org.uk (Phillip Lord)
Cc: acm@muc.de, 23785@debbugs.gnu.org
Subject: bug#23785: Emacs 25: 'Undo' overdoes things.
Date: Mon, 20 Jun 2016 10:04:01 -0400 [thread overview]
Message-ID: <jwvlh20yn66.fsf-monnier+bug#23785@gnu.org> (raw)
In-Reply-To: <874m8oc9hc.fsf@russet.org.uk> (Phillip Lord's message of "Mon, 20 Jun 2016 13:47:59 +0100")
> I don't understand why you say this. AFAICT, the problem is that the
> buffer-undo-list doesn't have a nil after the command has happened.
Hmm... I thought I had seen a trace showing that there was a nil before
the revert-buffer that then disappeared. But it looks like
I misremember. Sorry.
> I think that it does -- it calls "insert_from_buffer" which then calls
> "prepare_to_modify_buffer".
> I *think* what is happening is that prepare_to_modify_buffer is being
> called when buffer-undo-list is specbound to t -- hence the change does
> not register as undoable change.
That would be a good explanation, indeed. So I guess your patch is the
right fix. Thank you.
Stefan
next prev parent reply other threads:[~2016-06-20 14:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 15:02 bug#23785: Emacs 25: "Undo" overdoes things Alan Mackenzie
2016-06-17 17:15 ` Eli Zaretskii
2016-06-17 17:45 ` Alan Mackenzie
2016-06-17 20:07 ` Eli Zaretskii
2016-06-17 21:47 ` Phillip Lord
2016-06-18 4:46 ` Stefan Monnier
2016-06-18 7:54 ` Eli Zaretskii
2016-06-18 18:42 ` Stefan Monnier
2016-06-18 19:02 ` Eli Zaretskii
2016-06-18 19:52 ` Stefan Monnier
2016-06-19 22:45 ` bug#23785: Emacs 25: 'Undo' " Phillip Lord
2016-06-20 0:59 ` Stefan Monnier
2016-06-20 12:47 ` Phillip Lord
2016-06-20 14:04 ` Stefan Monnier [this message]
2016-06-20 15:03 ` Phillip Lord
2016-06-20 15:34 ` Eli Zaretskii
2016-06-20 17:12 ` Phillip Lord
2016-06-21 13:17 ` Eli Zaretskii
2016-06-21 14:30 ` Phillip Lord
2016-06-21 21:25 ` Stefan Monnier
2016-06-21 22:08 ` Phillip Lord
2020-09-04 14:03 ` Lars Ingebrigtsen
2020-09-05 13:15 ` Alan Mackenzie
2016-06-21 13:18 ` Eli Zaretskii
2016-06-21 14:29 ` Phillip Lord
2016-06-21 16:13 ` Eli Zaretskii
2016-06-17 21:23 ` bug#23785: Emacs 25: "Undo" " Phillip Lord
2016-06-18 17:41 ` Alan Mackenzie
2016-06-17 21:49 ` Óscar Fuentes
2016-06-20 12:33 ` Phillip Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='jwvlh20yn66.fsf-monnier+bug#23785@gnu.org' \
--to=monnier@iro.umontreal.ca \
--cc=23785@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=phillip.lord@russet.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.