From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master b7d8d3c 9/9: * fixtures/test/: Don't byte-compile Date: Sat, 06 Aug 2016 14:29:42 -0400 Message-ID: References: <20160805013757.31623.20092@vcs.savannah.gnu.org> <20160805013758.9B5BB2201A4@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1470508238 21999 195.159.176.226 (6 Aug 2016 18:30:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 6 Aug 2016 18:30:38 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: emacs-devel To: Jackson Hamilton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 06 20:30:34 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bW6Mi-0004pq-La for ged-emacs-devel@m.gmane.org; Sat, 06 Aug 2016 20:30:32 +0200 Original-Received: from localhost ([::1]:50263 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bW6Mf-0000iD-8S for ged-emacs-devel@m.gmane.org; Sat, 06 Aug 2016 14:30:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bW6M3-0000i8-Ss for emacs-devel@gnu.org; Sat, 06 Aug 2016 14:29:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bW6Lz-0000lj-Ly for emacs-devel@gnu.org; Sat, 06 Aug 2016 14:29:50 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:46546) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bW6Lz-0000le-AR for emacs-devel@gnu.org; Sat, 06 Aug 2016 14:29:47 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0A7FgA731xV/2/xd0tcgxCBMoJQhVXDCwQCAoE8PBEBAQEBAQEBgQpBBYNdAQEDAVYjBQsLNBIUGA0kE4gkCM8jAQEBBwIBH4s6hQUHhC0Fsz+BRSOBZoIuIjGCRwEBAQ X-IPAS-Result: A0A7FgA731xV/2/xd0tcgxCBMoJQhVXDCwQCAoE8PBEBAQEBAQEBgQpBBYNdAQEDAVYjBQsLNBIUGA0kE4gkCM8jAQEBBwIBH4s6hQUHhC0Fsz+BRSOBZoIuIjGCRwEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="250427771" Original-Received: from 75-119-241-111.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([75.119.241.111]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 06 Aug 2016 14:29:42 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 84DCFAE541; Sat, 6 Aug 2016 14:29:42 -0400 (EDT) In-Reply-To: (Jackson Hamilton's message of "Sat, 6 Aug 2016 10:42:55 -0700") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206461 Archived-At: > The contents of these test fixtures are significant. Changing them caused > the project's tests to fail. Hmm... indeed I see that now. > Can byte compilation be disabled for these > files without modifying their source? (For instance, by disabling > byte-compilation for the whole fixtures/ directory? Maybe through > .dir-locals.el? Or maybe by respecting .elpaignore?) Respecting .elpaignore would be perfect, indeed. But that file is using a format defined by tar, whereas I'd need to tweak the GNUmakefile rules to understand it, which is rather tricky. I'll see what I can come up with. Stefan > On Thu, Aug 4, 2016 at 6:37 PM, Stefan Monnier > wrote: >> branch: master >> commit b7d8d3ca7f1bc279a3e8b21646ccea481c93ed46 >> Author: Stefan Monnier >> Commit: Stefan Monnier >> >> * fixtures/test/: Don't byte-compile >> --- >> packages/context-coloring/fixtures/test/cond.el | 1 >> + >> packages/context-coloring/fixtures/test/condition-case.el | 1 >> + >> packages/context-coloring/fixtures/test/defun.el | 1 >> + >> packages/context-coloring/fixtures/test/ignored.el | 1 >> + >> packages/context-coloring/fixtures/test/let.el | 1 >> + >> packages/context-coloring/fixtures/test/macroexp-let2.el | 1 >> + >> packages/context-coloring/fixtures/test/unbalanced-parenthesis.el | 1 >> + >> packages/context-coloring/fixtures/test/varlist-spacing.el | 1 >> + >> 8 files changed, 8 insertions(+) >> >> diff --git a/packages/context-coloring/fixtures/test/cond.el >> b/packages/context-coloring/fixtures/test/cond.el >> index d5aae5b..5ed1ec2 100644 >> --- a/packages/context-coloring/fixtures/test/cond.el >> +++ b/packages/context-coloring/fixtures/test/cond.el >> @@ -1,3 +1,4 @@ >> +;; -*- no-byte-compile:t' -*- >> (let (a) >> (cond >> (a t) >> diff --git a/packages/context-coloring/fixtures/test/condition-case.el >> b/packages/context-coloring/fixtures/test/condition-case.el >> index 151f591..56a5f44 100644 >> --- a/packages/context-coloring/fixtures/test/condition-case.el >> +++ b/packages/context-coloring/fixtures/test/condition-case.el >> @@ -1,3 +1,4 @@ >> +;; -*- no-byte-compile:t' -*- >> (condition-case err >> (progn err free) >> (error err free) >> diff --git a/packages/context-coloring/fixtures/test/defun.el >> b/packages/context-coloring/fixtures/test/defun.el >> index 10a52f6..173ba0b 100644 >> --- a/packages/context-coloring/fixtures/test/defun.el >> +++ b/packages/context-coloring/fixtures/test/defun.el >> @@ -1,3 +1,4 @@ >> +;; -*- no-byte-compile:t' -*- >> (defun abc (def ghi &optional jkl) >> (+ def ghi jkl free)) >> >> diff --git a/packages/context-coloring/fixtures/test/ignored.el >> b/packages/context-coloring/fixtures/test/ignored.el >> index 1f5fd42..0c540ff 100644 >> --- a/packages/context-coloring/fixtures/test/ignored.el >> +++ b/packages/context-coloring/fixtures/test/ignored.el >> @@ -1,2 +1,3 @@ >> +;; -*- no-byte-compile:t' -*- >> (defun a () >> (+ a 1 +1 -1 1.0 #x0 ,a :a t nil (0 . 0))) >> diff --git a/packages/context-coloring/fixtures/test/let.el >> b/packages/context-coloring/fixtures/test/let.el >> index 49edb50..761a265 100644 >> --- a/packages/context-coloring/fixtures/test/let.el >> +++ b/packages/context-coloring/fixtures/test/let.el >> @@ -1,3 +1,4 @@ >> +;; -*- no-byte-compile:t' -*- >> (let (a >> (b a) >> (c free) >> diff --git a/packages/context-coloring/fixtures/test/macroexp-let2.el >> b/packages/context-coloring/fixtures/test/macroexp-let2.el >> index 1b61df2..97fbb23 100644 >> --- a/packages/context-coloring/fixtures/test/macroexp-let2.el >> +++ b/packages/context-coloring/fixtures/test/macroexp-let2.el >> @@ -1,3 +1,4 @@ >> +;; -*- no-byte-compile:t' -*- >> (let (exp) >> (macroexp-let2 macroexp-copyable-p v exp >> v exp)) >> diff --git a/packages/context-coloring/fixtures/test/unbalanced-parenthesis.el >> b/packages/context-coloring/fixtures/test/unbalanced-parenthesis.el >> index caaf7e2..e028aef 100644 >> --- a/packages/context-coloring/fixtures/test/unbalanced-parenthesis.el >> +++ b/packages/context-coloring/fixtures/test/unbalanced-parenthesis.el >> @@ -1,2 +1,3 @@ >> +;; -*- no-byte-compile:t' -*- >> (let ()) >> (let () >> diff --git a/packages/context-coloring/fixtures/test/varlist-spacing.el >> b/packages/context-coloring/fixtures/test/varlist-spacing.el >> index 97ec208..399cd18 100644 >> --- a/packages/context-coloring/fixtures/test/varlist-spacing.el >> +++ b/packages/context-coloring/fixtures/test/varlist-spacing.el >> @@ -1,3 +1,4 @@ >> +;; -*- no-byte-compile:t' -*- >> (let ( >> (a (lambda ())))) >> >>