From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master b7d8d3c 9/9: * fixtures/test/: Don't byte-compile Date: Sat, 17 Dec 2016 22:18:41 -0500 Message-ID: References: <20160805013757.31623.20092@vcs.savannah.gnu.org> <20160805013758.9B5BB2201A4@vcs.savannah.gnu.org> <357c3d56-6fe1-fcd1-8403-eaab95ab9af8@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1482031173 27370 195.159.176.226 (18 Dec 2016 03:19:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 18 Dec 2016 03:19:33 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: emacs-devel , Jackson Hamilton To: Jackson Ray Hamilton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 18 04:19:26 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cIS0T-0005dw-5P for ged-emacs-devel@m.gmane.org; Sun, 18 Dec 2016 04:19:25 +0100 Original-Received: from localhost ([::1]:39017 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cIS0X-0001nX-C4 for ged-emacs-devel@m.gmane.org; Sat, 17 Dec 2016 22:19:29 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cIRzt-0001mp-F2 for emacs-devel@gnu.org; Sat, 17 Dec 2016 22:18:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cIRzo-0000yt-C9 for emacs-devel@gnu.org; Sat, 17 Dec 2016 22:18:49 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:10980) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cIRzo-0000xv-5K for emacs-devel@gnu.org; Sat, 17 Dec 2016 22:18:44 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0BJJQAu3EVY/+J3oWxdGwEBAQMBAQEJAQEBgzgBAQEBAR8gOoEGgnuFVIR4lwoOGAGUVoIIIYV7BAICghFAFAECAQEBAQEBAWIohGkBBAFWIwULCzQSFBgNJIh6CK0Ui0QBAQgCJYsZiikFj3yKaoZLjQ6HQYY6kE6BQR83eBMOI4VQIDSIeQEBAQ X-IPAS-Result: A0BJJQAu3EVY/+J3oWxdGwEBAQMBAQEJAQEBgzgBAQEBAR8gOoEGgnuFVIR4lwoOGAGUVoIIIYV7BAICghFAFAECAQEBAQEBAWIohGkBBAFWIwULCzQSFBgNJIh6CK0Ui0QBAQgCJYsZiikFj3yKaoZLjQ6HQYY6kE6BQR83eBMOI4VQIDSIeQEBAQ X-IronPort-AV: E=Sophos;i="5.33,749,1477972800"; d="scan'208";a="283008972" Original-Received: from 108-161-119-226.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([108.161.119.226]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 17 Dec 2016 22:18:43 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id C4CF0AE113; Sat, 17 Dec 2016 22:18:41 -0500 (EST) In-Reply-To: <357c3d56-6fe1-fcd1-8403-eaab95ab9af8@gmail.com> (Jackson Ray Hamilton's message of "Sat, 17 Dec 2016 16:06:38 -0800") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210595 Archived-At: > Apparently, tar uses gnulib's excluded_file_name function, which appears > to delegate to fnmatch, which looks pretty complex to me. I'm not aware > of a "standalone" command providing an interface for this pattern > matcher, but if one exists, maybe we could utilize that. I think we could use sh's "case" patterns for that. > Another option might be to generate an archive with tar and then use the > list of included files to determine what to compile. This command: > > $ tar -ch packages/context-coloring/ --exclude-vcs -X \ > packages/context-coloring/.elpaignore | tar --list > > Produces this output: > packages/context-coloring/ > packages/context-coloring/LICENSE > packages/context-coloring/context-coloring-emacs-lisp.el > packages/context-coloring/README.md > packages/context-coloring/context-coloring-javascript.el > packages/context-coloring/context-coloring.el > > We could filter down the ".el" files from there. That might work as well, indeed. BTW, given the current GNUmakefile, it's easy/natural to only test .elpaignore matches for those files which end in .el and which don't yet have a .elc file. I expect this would be an important optimization to make sure that "make" is fast when there's not much to (re)compile. Stefan