From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#27016: possible bug in `defsetf' Date: Tue, 11 Jul 2017 22:01:14 -0400 Message-ID: References: <87h9075j12.fsf@users.sourceforge.net> <87injak1lj.fsf@users.sourceforge.net> <877ezp4v96.fsf@drachen> <871sppgyhb.fsf@users.sourceforge.net> <8760eyfp7s.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1499824932 18592 195.159.176.226 (12 Jul 2017 02:02:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 12 Jul 2017 02:02:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Michael Heerdegen , 27016@debbugs.gnu.org, Rafael D Sorkin To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 12 04:02:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dV6yb-0004We-Pu for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Jul 2017 04:02:05 +0200 Original-Received: from localhost ([::1]:49819 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dV6yh-0001XV-D6 for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Jul 2017 22:02:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42244) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dV6yb-0001XE-D9 for bug-gnu-emacs@gnu.org; Tue, 11 Jul 2017 22:02:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dV6yY-0005XA-CF for bug-gnu-emacs@gnu.org; Tue, 11 Jul 2017 22:02:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60066) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dV6yY-0005X5-83 for bug-gnu-emacs@gnu.org; Tue, 11 Jul 2017 22:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dV6yX-0003Tr-Tv for bug-gnu-emacs@gnu.org; Tue, 11 Jul 2017 22:02:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jul 2017 02:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27016 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27016-submit@debbugs.gnu.org id=B27016.149982488013325 (code B ref 27016); Wed, 12 Jul 2017 02:02:01 +0000 Original-Received: (at 27016) by debbugs.gnu.org; 12 Jul 2017 02:01:20 +0000 Original-Received: from localhost ([127.0.0.1]:34510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dV6xs-0003Sr-6H for submit@debbugs.gnu.org; Tue, 11 Jul 2017 22:01:20 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:46251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dV6xp-0003Sg-JP for 27016@debbugs.gnu.org; Tue, 11 Jul 2017 22:01:18 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v6C21EHf004854; Tue, 11 Jul 2017 22:01:15 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 6E3FE660B0; Tue, 11 Jul 2017 22:01:14 -0400 (EDT) In-Reply-To: <8760eyfp7s.fsf@users.sourceforge.net> (npostavs's message of "Tue, 11 Jul 2017 20:55:51 -0400") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6069=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6069> : inlines <5977> : streams <1753803> : uri <2461074> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134446 Archived-At: > I can see how that might work for function-get: > > (defun function-get (f prop &optional autoload) > ... > + (or > + (if (eq prop 'gv-expander) > + (alist-get f (alist-get :gv-expanders > + (bound-and-true-p > + byte-compile-macro-environment)))) > (let ((val nil)) > (while (and (symbolp f) > (null (setq val (get f prop))) > ;; etc... Why limit this to `gv-expander`? Also, we should probably move the test within the subsequent `while` loop, so that it interacts correctly with aliases. > But how can I make function-put do the right thing for both a macro > calling it and keep it's normal role? I don't know what to do when a macro calls it (I can't think of any reason we'd want to do that), but I know how to handle the case where a macro outputs code that uses it: Add (byte-defop-compiler-1 function-put) as well as a byte-compile-function-put function. See byte-compile-autoload and byte-compile-make-obsolete-variable for examples. Stefan