From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/ebdb 4206ccd 02/21: Don't unilaterally add to kill-emacs-hook Date: Sun, 17 Sep 2017 16:56:43 -0400 Message-ID: References: <20170917193244.24537.24926@vcs0.savannah.gnu.org> <20170917193245.721F520AB5@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1505681865 20372 195.159.176.226 (17 Sep 2017 20:57:45 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 17 Sep 2017 20:57:45 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Eric Abrahamsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 17 22:57:41 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtgdJ-000586-60 for ged-emacs-devel@m.gmane.org; Sun, 17 Sep 2017 22:57:41 +0200 Original-Received: from localhost ([::1]:33661 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dtgdQ-0007Pw-Fw for ged-emacs-devel@m.gmane.org; Sun, 17 Sep 2017 16:57:48 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dtgcp-0007Pg-VT for emacs-devel@gnu.org; Sun, 17 Sep 2017 16:57:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dtgcm-00048U-3r for emacs-devel@gnu.org; Sun, 17 Sep 2017 16:57:12 -0400 Original-Received: from pmta31.teksavvy.com ([76.10.157.38]:48016) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1dtgcT-0003x2-Dj for emacs-devel@gnu.org; Sun, 17 Sep 2017 16:57:07 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2HVBgDi4L5Z/xYMr7heGwEBAQMBAQEJA?= =?us-ascii?q?QEBg1qBUokphgeOfQGCIgGYCB2FIgQCAoQrWAECAQEBAQECA2gohRkGViMQCzQ?= =?us-ascii?q?SFBgNimquJ4sjAQEBAQYCJoMrhTWDKIVEhScFoQiWUIlLhzKVJYFJWIENMiEIM?= =?us-ascii?q?YYXgWokiyMBAQE?= X-IPAS-Result: =?us-ascii?q?A2HVBgDi4L5Z/xYMr7heGwEBAQMBAQEJAQEBg1qBUokphge?= =?us-ascii?q?OfQGCIgGYCB2FIgQCAoQrWAECAQEBAQECA2gohRkGViMQCzQSFBgNimquJ4sjA?= =?us-ascii?q?QEBAQYCJoMrhTWDKIVEhScFoQiWUIlLhzKVJYFJWIENMiEIMYYXgWokiyMBAQE?= X-IronPort-AV: E=Sophos;i="5.42,409,1500955200"; d="scan'208";a="4180641" Original-Received: from 184-175-12-22.dsl.teksavvy.com (HELO pastel.home) ([184.175.12.22]) by smtp.teksavvy.com with ESMTP; 17 Sep 2017 16:56:43 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 585666018D; Sun, 17 Sep 2017 16:56:43 -0400 (EDT) In-Reply-To: <20170917193245.721F520AB5@vcs0.savannah.gnu.org> (Eric Abrahamsen's message of "Sun, 17 Sep 2017 15:32:45 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 76.10.157.38 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218429 Archived-At: > +(defcustom ebdb-install-save-hook t > + "If non-nil, add `ebdb-save' to the hook `kill-emacs-hook'." > + :group 'ebdb-eieio > + :type 'boolean) I think the docstring should talk about the intended effect from the user's point of view, rather than from the implementation's point of view. I'm not 100% sure what is the intended effect, but it seems to be something like "automatically save EBDB when leaving Emacs". Stefan