all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Eric Abrahamsen <eric@ericabrahamsen.net>
Subject: Re: [elpa] externals/ebdb 4206ccd 02/21: Don't unilaterally add to kill-emacs-hook
Date: Sun, 17 Sep 2017 16:56:43 -0400	[thread overview]
Message-ID: <jwvlgldavus.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20170917193245.721F520AB5@vcs0.savannah.gnu.org> (Eric Abrahamsen's message of "Sun, 17 Sep 2017 15:32:45 -0400 (EDT)")

> +(defcustom ebdb-install-save-hook t
> +  "If non-nil, add `ebdb-save' to the hook `kill-emacs-hook'."
> +  :group 'ebdb-eieio
> +  :type 'boolean)

I think the docstring should talk about the intended effect from the
user's point of view, rather than from the implementation's point
of view.  I'm not 100% sure what is the intended effect, but it seems to
be something like "automatically save EBDB when leaving Emacs".


        Stefan



       reply	other threads:[~2017-09-17 20:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170917193244.24537.24926@vcs0.savannah.gnu.org>
     [not found] ` <20170917193245.721F520AB5@vcs0.savannah.gnu.org>
2017-09-17 20:56   ` Stefan Monnier [this message]
2017-09-17 21:37     ` [elpa] externals/ebdb 4206ccd 02/21: Don't unilaterally add to kill-emacs-hook Eric Abrahamsen
2017-09-17 21:40     ` Eric Abrahamsen
     [not found] ` <20170917193248.D117F20AB5@vcs0.savannah.gnu.org>
2017-09-17 20:59   ` [elpa] externals/ebdb 2b52686 18/21: Check type spec of slots that may or may not accept an object Stefan Monnier
2017-09-17 21:34     ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvlgldavus.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=eric@ericabrahamsen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.