From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#30955: 27.0.50; Mouse clicks on header-line in Info are broken Date: Thu, 29 Mar 2018 09:11:41 -0400 Message-ID: References: <83po3qga5g.fsf@gnu.org> <838tabdu3x.fsf@gnu.org> <83y3ibcbms.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1522329018 17009 195.159.176.226 (29 Mar 2018 13:10:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 29 Mar 2018 13:10:18 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: m43cap@yandex.com, 30955@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 29 15:10:14 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1XJg-0004EM-De for geb-bug-gnu-emacs@m.gmane.org; Thu, 29 Mar 2018 15:10:08 +0200 Original-Received: from localhost ([::1]:51486 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f1XLj-00025h-VW for geb-bug-gnu-emacs@m.gmane.org; Thu, 29 Mar 2018 09:12:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33133) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f1XLb-000240-HW for bug-gnu-emacs@gnu.org; Thu, 29 Mar 2018 09:12:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f1XLW-00045P-J2 for bug-gnu-emacs@gnu.org; Thu, 29 Mar 2018 09:12:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50245) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f1XLW-00045I-EX for bug-gnu-emacs@gnu.org; Thu, 29 Mar 2018 09:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f1XLV-0001fN-Uo for bug-gnu-emacs@gnu.org; Thu, 29 Mar 2018 09:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Mar 2018 13:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30955 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30955-submit@debbugs.gnu.org id=B30955.15223291066371 (code B ref 30955); Thu, 29 Mar 2018 13:12:01 +0000 Original-Received: (at 30955) by debbugs.gnu.org; 29 Mar 2018 13:11:46 +0000 Original-Received: from localhost ([127.0.0.1]:58142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1XLG-0001ef-HG for submit@debbugs.gnu.org; Thu, 29 Mar 2018 09:11:46 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:55531) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1XLD-0001eS-BQ for 30955@debbugs.gnu.org; Thu, 29 Mar 2018 09:11:44 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w2TDBf5x024579; Thu, 29 Mar 2018 09:11:41 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 7192E60559; Thu, 29 Mar 2018 09:11:41 -0400 (EDT) In-Reply-To: <83y3ibcbms.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 29 Mar 2018 15:24:59 +0300") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6253=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6253> : inlines <6528> : streams <1782603> : uri <2616834> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144686 Archived-At: Eli Zaretskii writes: >> From: Stefan Monnier >> Cc: 30955@debbugs.gnu.org, m43cap@yandex.com >> Date: Thu, 29 Mar 2018 08:10:03 -0400 >> >> There's indeed a bug, here, which is that it says >> >> (translated from ) >> >> instead of >> >> (translated from ) >> >> I assume it's because the fix I installed modifies the event in-place, >> so the recording of "untranslated events" gets changed by side-effect. > > I don't think so: I saw the mouse-2 part even before you fixed the > problem. Maybe you've seen it with yet-older code, such as the one in the emacs-26 branch (in that code, the mouse-1 => mouse-2 remapping was done elsewhere (i.e. as part of the processing of down-mouse-1) so read_key_sequence never even saw the mouse-1 event to put it into the raw_keybuf)? > So I think it's something else at work. Yet the second hunk below does fix this problem (the first hunk fixes the same problem but for C-h l, and the third just removes code which does something wrong, and I have no idea why the code was there in the first place). Stefan diff --git a/src/keyboard.c b/src/keyboard.c index 044e3fac69..6380e8585f 100644 --- a/src/keyboard.c +++ b/src/keyboard.c @@ -3258,7 +3258,10 @@ record_char (Lisp_Object c) if (!recorded) { total_keys += total_keys < NUM_RECENT_KEYS; - ASET (recent_keys, recent_keys_index, c); + ASET (recent_keys, recent_keys_index, + /* Copy the event, in case it gets modified by side-effect + by some remapping function. */ + CONSP (c) ? Fcopy_sequence (c) : c); if (++recent_keys_index >= NUM_RECENT_KEYS) recent_keys_index = 0; } @@ -9296,7 +9299,10 @@ read_key_sequence (Lisp_Object *keybuf, int bufsize, Lisp_Object prompt, } GROW_RAW_KEYBUF; - ASET (raw_keybuf, raw_keybuf_count, key); + ASET (raw_keybuf, raw_keybuf_count, + /* Copy the event, in case it gets modified by side-effect + by some remapping function. */ + CONSP (key) ? Fcopy_sequence (key) : key); raw_keybuf_count++; } @@ -9343,9 +9349,6 @@ read_key_sequence (Lisp_Object *keybuf, int bufsize, Lisp_Object prompt, && BUFFERP (XWINDOW (window)->contents) && XBUFFER (XWINDOW (window)->contents) != current_buffer) { - GROW_RAW_KEYBUF; - ASET (raw_keybuf, raw_keybuf_count, key); - raw_keybuf_count++; keybuf[t] = key; mock_input = t + 1;