From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.help Subject: Re: profiler-report seems to be missing data? Date: Thu, 16 Aug 2018 18:47:01 -0400 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1534459540 10956 195.159.176.226 (16 Aug 2018 22:45:40 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 16 Aug 2018 22:45:40 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Fri Aug 17 00:45:36 2018 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fqR1M-0002js-Ma for geh-help-gnu-emacs@m.gmane.org; Fri, 17 Aug 2018 00:45:36 +0200 Original-Received: from localhost ([::1]:58386 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fqR3T-0002an-Bs for geh-help-gnu-emacs@m.gmane.org; Thu, 16 Aug 2018 18:47:47 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fqR33-0002af-4b for help-gnu-emacs@gnu.org; Thu, 16 Aug 2018 18:47:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fqR2z-0001LN-Tf for help-gnu-emacs@gnu.org; Thu, 16 Aug 2018 18:47:21 -0400 Original-Received: from [195.159.176.226] (port=44470 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fqR2z-0001JW-Hu for help-gnu-emacs@gnu.org; Thu, 16 Aug 2018 18:47:17 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fqR0o-00023N-0I for help-gnu-emacs@gnu.org; Fri, 17 Aug 2018 00:45:02 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 27 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:geBzNrYw651iRxWBSlUhh5SOJ9s= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.org gmane.emacs.help:117680 Archived-At: > I'm trying to profile the usually excellent `find-things-fast` package to > figure out why it's slow in my project. The presence of `let*` in the profile indicates that the code is not byte-compiled. The difference in performance when byte-compiled can be large enough, so I'd suggest you first byte-compile your code and only then would I recommend you profile it (if still needed). > - # 1024 51% > - let* 1008 50% > cons 24 1% This suggests that a lot of time is spent in `let*` which may simply be because # is called many many times and doesn't do much more than `let*`. Looking at your function, I'm indeed surprised that even tough this `let*` was found 1008 times none of those times also found file-name-nondirectory or expand-file-name or gethash in the stack. Maybe this hints at a bug in the profiler code. Can you try and run this code many more times, so as to increase the "1008" to a larger number, making it yet more statistically unlikely that none of file-name-nondirectory or expand-file-name or gethash are found? Stefan