all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: John Shahid <jvshahid@gmail.com>
Cc: help-gnu-emacs@gnu.org
Subject: Re: call-process and incremental display of output
Date: Fri, 19 Oct 2018 22:06:54 -0400	[thread overview]
Message-ID: <jwvlg6tv0h6.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87sh113360.fsf@gmail.com> (John Shahid's message of "Fri, 19 Oct 2018 19:52:23 -0400")

> spin up a curl process that connects to our CI server and display the
> log output of a build.  The server stream the log output as a sequence
> of json messages that have to be parsed and appended to the buffer.  I
> used to do that with the following snippet of code:
>
>     (with-current-buffer log-buffer
>       (save-excursion
>         (goto-char (point-max))
>         (insert log-line)))

Ah, this one.

> FYI, what I currently have is something like this:
>
>     (let ((pos (copy-marker (point) t)))
>       (ignore-errors
>         (goto-char (point-max))
>         (insert payload))
>       (goto-char pos))

Yes, many/most process filters end up doing that (tho others use
insert-before-markers instead, which comes with other problems).

Given how pervasively save-excursion is used, I think changing its
behavior is very risky.  Admittedly, it didn't prevent me from changing
it by dropping the mark handling from it.
And window-point-insertion-type is used fairly rarely, so maybe the
impact would not be quite as widespread as it seems.

Anyway, it's luckily not my call to make ;-)

I'd suggest you try running with such a change for some months, trying
to use a variety of packages and see if you bump into problems.


        Stefan



  reply	other threads:[~2018-10-20  2:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-16 13:25 call-process and incremental display of output Florian Weimer
2018-10-16 14:21 ` Michael Albinus
2018-10-16 14:26   ` Florian Weimer
2018-10-16 14:32     ` Michael Albinus
2018-10-16 14:36 ` Stefan Monnier
2018-10-17  8:32   ` Florian Weimer
2018-10-17  9:21     ` tomas
2018-10-17  9:34       ` Florian Weimer
2018-10-17  9:40         ` tomas
2018-10-17 14:59     ` Stefan Monnier
2018-10-19 21:40       ` John Shahid
2018-10-19 22:05         ` Stefan Monnier
2018-10-19 23:52           ` John Shahid
2018-10-20  2:06             ` Stefan Monnier [this message]
2018-10-21 17:05               ` John Shahid
     [not found]                 ` <jwv36szqj1d.fsf-monnier+emacs@gnu.org>
2018-12-26 17:47                   ` John Shahid
2019-02-27 12:59                     ` John Shahid
2019-02-27 14:11                       ` Stefan Monnier
2019-02-28 19:16                         ` John Shahid
2019-02-28 21:56                           ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvlg6tv0h6.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=help-gnu-emacs@gnu.org \
    --cc=jvshahid@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.