From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 197bf4e: Fix build fail on files.el change (Bug#32352) Date: Tue, 13 Nov 2018 08:57:22 -0500 Message-ID: References: <20181113135009.11956.80188@vcs0.savannah.gnu.org> <20181113135010.80DB3209E4@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1542117418 15657 195.159.176.226 (13 Nov 2018 13:56:58 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 13 Nov 2018 13:56:58 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 13 14:56:53 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gMZBV-0003yG-6S for ged-emacs-devel@m.gmane.org; Tue, 13 Nov 2018 14:56:53 +0100 Original-Received: from localhost ([::1]:54114 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMZDb-0008UP-LQ for ged-emacs-devel@m.gmane.org; Tue, 13 Nov 2018 08:59:03 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMZCW-0008TC-RI for emacs-devel@gnu.org; Tue, 13 Nov 2018 08:57:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gMZCS-0004Uj-Ji for emacs-devel@gnu.org; Tue, 13 Nov 2018 08:57:56 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:37451) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMZCR-00047C-AY for emacs-devel@gnu.org; Tue, 13 Nov 2018 08:57:52 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id wADDvMCu001158; Tue, 13 Nov 2018 08:57:22 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 4C0896069D; Tue, 13 Nov 2018 08:57:22 -0500 (EST) In-Reply-To: <20181113135010.80DB3209E4@vcs0.savannah.gnu.org> (Noam Postavsky's message of "Tue, 13 Nov 2018 08:50:10 -0500 (EST)") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6417=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6417> : inlines <6959> : streams <1804151> : uri <2748973> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231111 Archived-At: > Fix build fail on files.el change (Bug#32352) > > * lisp/files.el (dir-locals-read-from-dir): Reduce scope of > `read-circle' let-binding to go around the `read' call only. > Otherwise it can interfere with loading of files which use the > circular read syntax (e.g., executing the setf expression in > `dir-locals-set-class-variables' may require loading gv.elc). Ha! Good catch! Thanks for tracking this down (it got me stumped). Stefan