* What is an "input event"?
@ 2018-11-21 16:12 Stefan Monnier
2018-11-23 7:41 ` martin rudalics
2018-11-23 10:28 ` Eli Zaretskii
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Monnier @ 2018-11-21 16:12 UTC (permalink / raw)
To: emacs-devel
Looking at the doc of last-repeatable-command I think we should clarify
what we mean by "input event". The docstring says:
Last command that may be repeated.
The last command executed that was not bound to an input event.
This is the command ‘repeat’ will try to repeat.
Taken from a previous value of ‘real-this-command’.
and the manual says:
This variable stores the most recently executed command that was not
part of an input event. This is the command @code{repeat} will try to
repeat, @xref{Repeating,,, emacs, The GNU Emacs Manual}.
but according to the source code, this variable holds the last command
that was run via a "simple" event such as a keyboard key rather than
a "complex" event like a mouse click (the test is simply CONSP).
Do we somewhere define "input event" to mean an event with parameters?
I thought keyboard keys are also "input events".
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: What is an "input event"?
2018-11-21 16:12 What is an "input event"? Stefan Monnier
@ 2018-11-23 7:41 ` martin rudalics
2018-11-23 10:28 ` Eli Zaretskii
1 sibling, 0 replies; 3+ messages in thread
From: martin rudalics @ 2018-11-23 7:41 UTC (permalink / raw)
To: Stefan Monnier, emacs-devel
> Looking at the doc of last-repeatable-command I think we should clarify
> what we mean by "input event". The docstring says:
>
> Last command that may be repeated.
> The last command executed that was not bound to an input event.
> This is the command ‘repeat’ will try to repeat.
> Taken from a previous value of ‘real-this-command’.
>
> and the manual says:
>
> This variable stores the most recently executed command that was not
> part of an input event. This is the command @code{repeat} will try to
> repeat, @xref{Repeating,,, emacs, The GNU Emacs Manual}.
>
> but according to the source code, this variable holds the last command
> that was run via a "simple" event such as a keyboard key rather than
> a "complex" event like a mouse click (the test is simply CONSP).
>
> Do we somewhere define "input event" to mean an event with parameters?
> I thought keyboard keys are also "input events".
IIRC this was to avoid repeating commands like 'handle-switch-frame'.
How should we verbally distinguish such commands from the ones we want
to consider repeatable?
martin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: What is an "input event"?
2018-11-21 16:12 What is an "input event"? Stefan Monnier
2018-11-23 7:41 ` martin rudalics
@ 2018-11-23 10:28 ` Eli Zaretskii
1 sibling, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2018-11-23 10:28 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Wed, 21 Nov 2018 11:12:15 -0500
>
> Looking at the doc of last-repeatable-command I think we should clarify
> what we mean by "input event". The docstring says:
>
> Last command that may be repeated.
> The last command executed that was not bound to an input event.
> This is the command ‘repeat’ will try to repeat.
> Taken from a previous value of ‘real-this-command’.
>
> and the manual says:
>
> This variable stores the most recently executed command that was not
> part of an input event. This is the command @code{repeat} will try to
> repeat, @xref{Repeating,,, emacs, The GNU Emacs Manual}.
>
> but according to the source code, this variable holds the last command
> that was run via a "simple" event such as a keyboard key rather than
> a "complex" event like a mouse click (the test is simply CONSP).
>
> Do we somewhere define "input event" to mean an event with parameters?
"Input Events" in the ELisp manual. Which describes quite a few
classes of input events.
> I thought keyboard keys are also "input events".
Yes, keyboard input also counts as input events.
Those documentation parts should say "non-keyboard input events", or
something like that.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-23 10:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-21 16:12 What is an "input event"? Stefan Monnier
2018-11-23 7:41 ` martin rudalics
2018-11-23 10:28 ` Eli Zaretskii
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.