* Re: master 0cef057: * test/lisp/progmodes/python-tests.el: "Fix" failing test [not found] ` <20190410143955.65B6320619@vcs0.savannah.gnu.org> @ 2019-04-11 8:05 ` Michael Albinus 2019-04-11 14:33 ` Stefan Monnier 0 siblings, 1 reply; 3+ messages in thread From: Michael Albinus @ 2019-04-11 8:05 UTC (permalink / raw) To: emacs-devel; +Cc: Stefan Monnier monnier@iro.umontreal.ca (Stefan Monnier) writes: Hi Stefan, > * test/lisp/progmodes/python-tests.el: "Fix" failing test > > (python-tests--python-nav-end-of-statement--infloop): Disable. > > --- a/test/lisp/progmodes/python-tests.el > +++ b/test/lisp/progmodes/python-tests.el > @@ -5345,13 +5345,23 @@ class SomeClass: > (ert-deftest python-tests--python-nav-end-of-statement--infloop () > "Checks that `python-nav-end-of-statement' doesn't infloop in a > buffer with overlapping strings." > + ;; FIXME: The treatment of strings has changed in the mean time, and the > + ;; test below now neither signals an error nor inf-loops. > + ;; The description of the problem it's trying to catch is not clear enough > + ;; to be able to see if the underlying problem is really fixed, sadly. > + ;; E.g. I don't know what is meant by "overlap", really. > + (skip-unless nil) The way to do this is :tags '(:unstable) This prevents the test to run via any make target, but the author is still able to run the test with a proper selector, working on this. See also .../test/README Best regards, Michael. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 0cef057: * test/lisp/progmodes/python-tests.el: "Fix" failing test 2019-04-11 8:05 ` master 0cef057: * test/lisp/progmodes/python-tests.el: "Fix" failing test Michael Albinus @ 2019-04-11 14:33 ` Stefan Monnier 2019-04-11 14:49 ` Michael Albinus 0 siblings, 1 reply; 3+ messages in thread From: Stefan Monnier @ 2019-04-11 14:33 UTC (permalink / raw) To: emacs-devel > The way to do this is > :tags '(:unstable) Hmm... That's not documented in the ert-deftest docstring. Stefan ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 0cef057: * test/lisp/progmodes/python-tests.el: "Fix" failing test 2019-04-11 14:33 ` Stefan Monnier @ 2019-04-11 14:49 ` Michael Albinus 0 siblings, 0 replies; 3+ messages in thread From: Michael Albinus @ 2019-04-11 14:49 UTC (permalink / raw) To: Stefan Monnier; +Cc: emacs-devel Stefan Monnier <monnier@iro.umontreal.ca> writes: >> The way to do this is >> :tags '(:unstable) > > Hmm... That's not documented in the ert-deftest docstring. Sure. ERT does not predefine tags, they are free text (symbols). And tags have no meaning for ERT but being usable for selectors. That's why it is documented in Emacs' test/README. Outside Emacs' Makefile, the tag :unstable doesn't mean anything. > Stefan Best regards, Michael. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-11 14:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190410143954.15970.66756@vcs0.savannah.gnu.org>
[not found] ` <20190410143955.65B6320619@vcs0.savannah.gnu.org>
2019-04-11 8:05 ` master 0cef057: * test/lisp/progmodes/python-tests.el: "Fix" failing test Michael Albinus
2019-04-11 14:33 ` Stefan Monnier
2019-04-11 14:49 ` Michael Albinus
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.