From: Stefan Monnier <monnier@iro.umontreal.ca>
To: phillip.lord@russet.org.uk
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
36598@debbugs.gnu.org, mah@everybody.org
Subject: bug#36598: 26.1; (error "‘/tmp/emacs1000’ is not a safe directory because it is a symlink")
Date: Mon, 15 Jul 2019 09:04:22 -0400 [thread overview]
Message-ID: <jwvlfwzpi04.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20a62c04ad67dc64665b32d7a31cfe8b@russet.org.uk> (phillip lord's message of "Sun, 14 Jul 2019 20:11:31 +0100")
>> Commit b663c837249 (in May) which says "Cosmetic changes" is the one
>> that introduced this code?
>>
>> (let ((olddir (or (getenv "TMPDIR") "/tmp")))
>> (when (and (equal dir (format "%s/emacs" (getenv
>> "XDG_RUNTIME_DIR")))
>> (file-writable-p olddir))
>> (let ((link (format "%s/emacs%d" olddir (user-uid))))
>> (unless (file-directory-p link)
>> ;; We're using the new location, so try and setup a symlink
>> from
>> ;; the old location, in case we want to use an
>> old emacsclient.
>> ;; FIXME: Check that it's safe to use!
>> (make-symbolic-link dir link t)))))
>>
>> And instead of making things work with an old emacsclient, it breaks the
>> Emacs 26 emacsclient?
>
> Nearly. I think it breaks emacs-26 not the emacsclient. I haven't check the
> emacsclient code, but I guess Stefan was
> aiming for the situation when someone is using (say) emacsclient-26 with
> emacs-27.
Indeed (it's Debian/s /usr/bin/emacsclient accessing my hand-built
Emacs-27 server).
>> Stefan, was this checked in by mistake?
Definitely,
Stefan
next prev parent reply other threads:[~2019-07-15 13:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 14:10 bug#36598: 26.1; (error "‘/tmp/emacs1000’ is not a safe directory because it is a symlink") Mark A. Hershberger
2019-07-13 4:38 ` Lars Ingebrigtsen
2019-07-13 14:30 ` phillip.lord
2019-07-13 14:45 ` Lars Ingebrigtsen
2019-07-13 15:56 ` phillip.lord
2019-07-14 1:43 ` Glenn Morris
2019-07-14 11:44 ` Lars Ingebrigtsen
2019-07-14 19:11 ` phillip.lord
2019-07-15 13:04 ` Stefan Monnier [this message]
2019-07-18 6:27 ` Eli Zaretskii
2019-07-23 12:07 ` Noam Postavsky
2019-07-13 12:46 ` Noam Postavsky
2019-07-13 13:06 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvlfwzpi04.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=36598@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=mah@everybody.org \
--cc=phillip.lord@russet.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.