From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Date: Fri, 31 Jan 2020 08:17:12 -0500 Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <2a56337b-50f6-38a1-a73f-8a4cbdda22f0@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="69249"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 38992@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , waah@yellowfrog.io To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 31 14:18:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ixWBZ-000HwC-62 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 31 Jan 2020 14:18:13 +0100 Original-Received: from localhost ([::1]:52964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixWBX-0004sN-Sv for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 31 Jan 2020 08:18:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52553) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixWBP-0004s5-JI for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 08:18:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ixWBO-0005ZP-LJ for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 08:18:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58936) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ixWBO-0005Yc-Er for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 08:18:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ixWBO-0000MT-AZ for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 08:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 Jan 2020 13:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs Original-Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15804766431344 (code B ref 38992); Fri, 31 Jan 2020 13:18:02 +0000 Original-Received: (at 38992) by debbugs.gnu.org; 31 Jan 2020 13:17:23 +0000 Original-Received: from localhost ([127.0.0.1]:36676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixWAl-0000Lb-Es for submit@debbugs.gnu.org; Fri, 31 Jan 2020 08:17:23 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:17404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixWAj-0000LO-K6 for 38992@debbugs.gnu.org; Fri, 31 Jan 2020 08:17:22 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A5978100A27; Fri, 31 Jan 2020 08:17:15 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D548C100943; Fri, 31 Jan 2020 08:17:13 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1580476633; bh=FJ/AFDfYqh0qKpS8/gMW9jERbYhB2/Jgc5RgORxFfJc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=hhM9QQwdPJnueHjMB9YVrcO3dKqaLcikzsGunLeSy8MAq4vcRsuRSIGE0dNYhwXhd i7r6bsSDmLCHza9O18cEoG8CJHVgh0RzwaCBMY7Ku+noMdlcw2ZrpsYgZNxuKIfaps AcMkjUVYL/3+tJo0knYaLmWSS3DrylVcazSVeEmz3eo6ZOoNplYXJkMCk38bDbqEp/ 7vtJT3LfL3YSte5gamYqva2gutmbkCkSkQkF04cDsK5CqGlkZXCr/OCq52K/oqvmMN JoYmNnt5rQ/BscaRA5XLrX+UST+71ZfARRgJzlQA2BhLUs4uKW4myoqiBnvD65gQb9 jbTxUciLq89kg== Original-Received: from pastel (unknown [45.72.213.248]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 865FC121015; Fri, 31 Jan 2020 08:17:13 -0500 (EST) In-Reply-To: <2a56337b-50f6-38a1-a73f-8a4cbdda22f0@yandex.ru> (Dmitry Gutov's message of "Fri, 31 Jan 2020 04:48:16 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175484 Archived-At: >> Maybe it used to be that `minibuffer-completion-confirm` used to be set >> to something like (not (memq require-match '(nil t)))? > Not exactly. It was set to (not require-match), basically. Ah, sounds right. > The last place that changed was commit 695deb1857d, almost 18 years ago by > your hand. Guilty as charged (IIRC this was done when I added the ability for `C-x C-f` and `C-x b` to ask for confirmation before opening a new file/buffer). > Speaking of, there's this condition in icomplete-exhibit that computes the > require-match argument of icomplete-completions as > > (if (window-minibuffer-p) > (not minibuffer-completion-confirm)) > > but it only affects cosmetics. It seems wrong (to me) now, but it makes > sense looking at the code before the aforementioned commit. I wouldn't be surprised that I missed some spots, back then, indeed. Stefan