From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.help Subject: Re: x-clipboard-yank insert kill-ring entry instead of primary selection Date: Mon, 02 Mar 2020 14:56:32 -0500 Message-ID: References: <831rqeho9f.fsf@gnu.org> <73781ecb442d054133e5fe81bd0c1805@posteo.net> <83lfoiy9xs.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="49829"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: help-gnu-emacs@gnu.org Cancel-Lock: sha1:qwhuYeWxcNUKG/KmYj2h38D6Wzw= Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 02 20:57:00 2020 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j8rBU-000Cra-0R for geh-help-gnu-emacs@m.gmane-mx.org; Mon, 02 Mar 2020 20:57:00 +0100 Original-Received: from localhost ([::1]:38018 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8rBT-0004BL-2C for geh-help-gnu-emacs@m.gmane-mx.org; Mon, 02 Mar 2020 14:56:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32933) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8rBA-0004Aw-2k for help-gnu-emacs@gnu.org; Mon, 02 Mar 2020 14:56:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8rB9-00085h-31 for help-gnu-emacs@gnu.org; Mon, 02 Mar 2020 14:56:40 -0500 Original-Received: from ciao.gmane.io ([159.69.161.202]:44230) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j8rB8-00085P-TE for help-gnu-emacs@gnu.org; Mon, 02 Mar 2020 14:56:39 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1j8rB7-000CWt-3x for help-gnu-emacs@gnu.org; Mon, 02 Mar 2020 20:56:37 +0100 X-Injected-Via-Gmane: http://gmane.org/ X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 159.69.161.202 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:122512 Archived-At: >> -(defun mouse-yank-primary (click) >> - "Insert the primary selection at the position clicked on. >> +(defun mouse-yank-primary (&optional event) >> + "Insert the primary selection. > > A nit: a command that can be invoked not by mouse shouldn't be called > "mouse-SOMETHING". ;-) I had the exact same reaction while writing the code. Then again, mouse-set-point works with non-mouse events and I'm guessing that many/most other commands in mouse.el can work with non-mouse events. Not sure what we should do about it. Renaming them all seems too much trouble. And they were all written with the mouse as the main use case. And they are all in mouse.el. So I'm thinking maybe we can keep the "mouse-" prefix not to mean "only useful for the mouse" but "originally introduced for the mouse" or ¨found in mouse.el". Stefan