From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] pcase.el: Add type pattern Date: Mon, 16 Mar 2020 08:59:24 -0400 Message-ID: References: <874kuxxuez.fsf@alphapapa.net> <87r1y1wcj4.fsf@alphapapa.net> <87h7yxw5x1.fsf@alphapapa.net> <87a74puq1q.fsf@web.de> <87d09lw3id.fsf@alphapapa.net> <87zhcoqmmz.fsf@web.de> <87wo7s8b73.fsf@alphapapa.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="95567"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Adam Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 16 16:10:43 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jDrO6-000Ojz-MW for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Mar 2020 16:10:42 +0100 Original-Received: from localhost ([::1]:39422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDrO5-0007ZH-4A for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Mar 2020 11:10:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54219) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDpLC-0008NP-IY for emacs-devel@gnu.org; Mon, 16 Mar 2020 08:59:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jDpLA-0000mk-RZ for emacs-devel@gnu.org; Mon, 16 Mar 2020 08:59:33 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:23340) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jDpLA-0000cP-Iu for emacs-devel@gnu.org; Mon, 16 Mar 2020 08:59:32 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D45C9100865; Mon, 16 Mar 2020 08:59:31 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3FDFB100B45; Mon, 16 Mar 2020 08:59:30 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1584363570; bh=z/m4ZCkFwkNp5zVyj6Z+l0WdfqnWl35IIurYRYbgZrs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=GAXb9YCXjKs15uomzGIIgEiE7SymMsy1HULOV/hvN5PBu7YIyFdrMOX0xEf3tY8PV UC8vh0bb9Kr6SeAXCTE8RBf4QN2rPC3Zr5XLYgokZzv1RoXvhCWLja/0sJAvQYVCdZ AqZ6zY59HFr24910fhm6y6vaOgdf4UtRgN8vi1PxPNzD9EkB9zPxy/yMi05iSImy0W g8S/5E2kQBphmm326+BtnrDqQA9xAQBPSMCQxBux+mHiLq6z5OeHsv2GtYgSdFAWCy BwbyUsHDtfRPUbGXdQW+hHwiAbs8ZyMIOiDd9EHaBMMdCtaRIvHhq+wGt7WvHSOiSl knI3nXSWpY1Iw== Original-Received: from pastel (unknown [216.154.50.221]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 19F901206A7; Mon, 16 Mar 2020 08:59:30 -0400 (EDT) In-Reply-To: <87wo7s8b73.fsf@alphapapa.net> (Adam Porter's message of "Tue, 10 Mar 2020 10:46:24 -0500") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:245550 Archived-At: > Thanks, that's a good point. This new patch improves the docstring and > the changes to the manual, and it adds a test for a cl-typep list form. > Please let me know if more improvements should be made. The code looks good, except for the fact that it only works after (require 'cl-lib), so if we want to put it into `cl-lib` like that, we should use a name like `cl-type` rather than `type`. Stefan