From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master c59e878: Inhibit modification hooks when saving eieio-persistent's Date: Sat, 02 May 2020 09:32:24 -0400 Message-ID: References: <20200501192115.23847.67499@vcs0.savannah.gnu.org> <20200501192116.A55EE20B5B@vcs0.savannah.gnu.org> <878sib8apd.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="53356"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Michael Heerdegen , emacs-devel@gnu.org To: Eric Abrahamsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 02 15:33:02 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jUsGM-000Dls-2O for ged-emacs-devel@m.gmane-mx.org; Sat, 02 May 2020 15:33:02 +0200 Original-Received: from localhost ([::1]:33194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUsGK-0004eu-RF for ged-emacs-devel@m.gmane-mx.org; Sat, 02 May 2020 09:33:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUsFp-00049k-Jd for emacs-devel@gnu.org; Sat, 02 May 2020 09:32:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUsFo-0004zP-EX for emacs-devel@gnu.org; Sat, 02 May 2020 09:32:28 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:41580) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUsFo-0004xH-1h for emacs-devel@gnu.org; Sat, 02 May 2020 09:32:28 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id F3D2945081F; Sat, 2 May 2020 09:32:26 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 796DC45081A; Sat, 2 May 2020 09:32:25 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1588426345; bh=cYFHS9E0CCYWLgUMv7Ri4qDuOUq6kstv4/eikdZqmVU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Apro+r0xVjtH/LSrQGNcTCdYZax6QuLiDZEk7q0oxo6AWl4uR+MnAkAN5XCBGZmEH l7Ma41nFj11srWDpYBz7MQQN9QAKMpV5gw6juzzT1qofK9j+HmGmRJk8eb0xMxFrt3 EY0fHuNazZHuepu04GIicQ5wFtEcMIDc4EtBIhhBoS+W+7+v/F3xBmV6mJpfZ3sm+Z p4TV+P+wIHJHy9QjTVCrl7aCR2k5udwUxPzJlhvx3oXsNRfFJi2BTCULhtpdlCwwyx WFUhmz7DRJvjADq8TuqHK+zFXmnRNfVSVPG/SGgOht/ABQQVGhVMarbLzc23IO4gUm UU64vqXfSGbgQ== Original-Received: from alfajor (unknown [216.154.3.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 466DC120769; Sat, 2 May 2020 09:32:25 -0400 (EDT) In-Reply-To: <878sib8apd.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Fri, 01 May 2020 17:03:26 -0700") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/02 08:59:26 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:248433 Archived-At: > I'm curious what the objection is -- why would we *want* modification > hooks to run when writing an eieio object out to file? Do you know what modification hooks are used for? I know some uses, but not all. So it's pretty hard to convince myself that there really can't be any good reason why someone might want those hooks to be run. More importantly, `inhibit-modification-hooks` is bound here globally, so it will affect behavior of Emacs not just in that temp buffer if some code happens to modify other buffers during execution of this code. That can be *anything* when you debug the code or when you run a sufficiently interesting `object-write` method. Stefan