From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 263ab75: ; Fix recent byte-compiler warning in dnd.el again Date: Thu, 07 May 2020 16:55:26 -0400 Message-ID: References: <20200507174021.29070.24637@vcs0.savannah.gnu.org> <20200507174022.5B7BD20A15@vcs0.savannah.gnu.org> <87h7wrmr7g.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="34717"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 07 22:56:02 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWnYn-0008tT-EM for ged-emacs-devel@m.gmane-mx.org; Thu, 07 May 2020 22:56:01 +0200 Original-Received: from localhost ([::1]:37728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWnYm-0007Yn-Hf for ged-emacs-devel@m.gmane-mx.org; Thu, 07 May 2020 16:56:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50790) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWnYJ-00079n-KF for emacs-devel@gnu.org; Thu, 07 May 2020 16:55:31 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:18255) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWnYI-00045P-5W for emacs-devel@gnu.org; Thu, 07 May 2020 16:55:30 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id EF301450A66; Thu, 7 May 2020 16:55:28 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6BC92450A62; Thu, 7 May 2020 16:55:27 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1588884927; bh=HbpPcRelMaBTihFbDSMyc8RvgcZUUEPe/s6eL9j6iGE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=FN+t52JoOsxhL0oM40iJA+EWb/LkBc4Q/8rG7hfGiQ9krxCpf4DLE/BTXRXD7XSXm zQwZPVKtYWB3rYNjNPgvFCsSX9rf+VIULaj6IsIv6wHDbAkJhwWZF66PwybDPuRAV9 CIlTsJhlkk07fMDcCTXJlJFjp/rQXbgQCpTN2luvSLEqiDQDwZElDS3gwiJmrUrpqg CQy3rsTFAGqZdjKTFwjESZ+YIfboSSpfIFEJ6ch0iQqofPFVlqlYD0mSmYCCGf24lr OwMvjIRp+iem8HPg8D6EaU+yu7PqNO6hZ4dZhtmdVtY9umSYlV1CpeB6VM4dXxKIAG X0Clx7E9mRLgQ== Original-Received: from alfajor (unknown [216.154.3.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3494A120547; Thu, 7 May 2020 16:55:27 -0400 (EDT) In-Reply-To: <87h7wrmr7g.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 07 May 2020 21:21:23 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/07 14:17:40 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:249220 Archived-At: >> It complains because the ;;;###autoload cookie had not yet been turned >> into an actual autoload in `lisp/loaddefs.el`. >> IOW what was missing was `cd lisp; make autoloads`. > > That was my first thought as well, but 'make bootstrap' was still > complaining after verifying > > $ grep browse-url-select-handler lisp/loaddefs.el > (autoload 'browse-url-select-handler "browse-url" "\ Hmm... that's odd. I removed the declare-function, then did: (cd lisp; make autoloads); make` and the warning was still gone. I can imagine the warning sticking around if you do cd lisp; make autoloads; make because then you only recompile `lisp/dnd.el` without first rebuilding Emacs with the new `lisp/loaddefs.el`, but in the case of bootstrap I can't see why the warning would linger (my machine's weak CPU makes it much too painful to do a bootstrap so I haven't tested that case). > so I assumed the warning was due to bootstrapping order and added the > declaration anyway. I guess that's possible. In that case the warning should disappear when lisp/ldefs-boot.el is updated. >> I also get caught by those things every once in a while. >> It would be good to find a way to automatically guess when to run `make autoloads`. > Is it run in time as part of 'make bootstrap'? Yes. Stefan