all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: emacs-devel@gnu.org
Subject: Re: master 263ab75: ; Fix recent byte-compiler warning in dnd.el again
Date: Thu, 07 May 2020 16:55:26 -0400	[thread overview]
Message-ID: <jwvlfm3zd1r.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87h7wrmr7g.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 07 May 2020 21:21:23 +0100")

>> It complains because the ;;;###autoload cookie had not yet been turned
>> into an actual autoload in `lisp/loaddefs.el`.
>> IOW what was missing was `cd lisp; make autoloads`.
>
> That was my first thought as well, but 'make bootstrap' was still
> complaining after verifying
>
>   $ grep browse-url-select-handler lisp/loaddefs.el
>   (autoload 'browse-url-select-handler "browse-url" "\

Hmm... that's odd.
I removed the declare-function, then did:

    (cd lisp; make autoloads); make`

and the warning was still gone.
I can imagine the warning sticking around if you do

    cd lisp; make autoloads; make

because then you only recompile `lisp/dnd.el` without first rebuilding
Emacs with the new `lisp/loaddefs.el`, but in the case of bootstrap
I can't see why the warning would linger (my machine's weak CPU makes
it much too painful to do a bootstrap so I haven't tested that case).

> so I assumed the warning was due to bootstrapping order and added the
> declaration anyway.

I guess that's possible.  In that case the warning should disappear
when lisp/ldefs-boot.el is updated.

>> I also get caught by those things every once in a while.
>> It would be good to find a way to automatically guess when to run `make autoloads`.
> Is it run in time as part of 'make bootstrap'?

Yes.


        Stefan




  reply	other threads:[~2020-05-07 20:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200507174021.29070.24637@vcs0.savannah.gnu.org>
     [not found] ` <20200507174022.5B7BD20A15@vcs0.savannah.gnu.org>
2020-05-07 19:05   ` master 263ab75: ; Fix recent byte-compiler warning in dnd.el again Stefan Monnier
2020-05-07 20:21     ` Basil L. Contovounesios
2020-05-07 20:55       ` Stefan Monnier [this message]
2020-05-07 23:12         ` Basil L. Contovounesios
2020-06-13 15:16           ` Basil L. Contovounesios

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvlfm3zd1r.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=contovob@tcd.ie \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.