all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Philipp Stephani <p.stephani2@gmail.com>,
	Noam Postavsky <npostavs@gmail.com>,
	43329@debbugs.gnu.org
Subject: bug#43329: 28.0.50; Incorrect indentation for variables starting with `def' in let form
Date: Sat, 12 Sep 2020 11:48:21 -0400	[thread overview]
Message-ID: <jwvlfhfatfm.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87h7s32ooe.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 12 Sep 2020 13:57:05 +0200")

> Would something as simple as the following (which fixes this use case)
> be the correct fix?  It only indents these forms as macros if they are
> top-level...

It obviously has the downside of not indenting properly those
definitions which are not at the very-top level.  E.g. definitions
inside an `eval-when-compile` or other.


        Stefan






  reply	other threads:[~2020-09-12 15:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-11 10:10 bug#43329: 28.0.50; Incorrect indentation for variables starting with `def' in let form Philipp Stephani
2020-09-11 10:26 ` Lars Ingebrigtsen
2020-09-11 16:35   ` Noam Postavsky
2020-09-12 11:57     ` Lars Ingebrigtsen
2020-09-12 15:48       ` Stefan Monnier [this message]
2020-09-13 12:44         ` Lars Ingebrigtsen
2020-09-13 15:24           ` Stefan Monnier
2020-09-13 17:20             ` Lars Ingebrigtsen
2021-10-13 19:23               ` Lars Ingebrigtsen
2021-10-18  8:00                 ` bug#43329: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvlfhfatfm.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=43329@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=npostavs@gmail.com \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.